Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix readall and isexecutable deprecations #40

Merged
merged 1 commit into from
Feb 11, 2016

Conversation

jdlangs
Copy link
Contributor

@jdlangs jdlangs commented Feb 10, 2016

Switching isexecutable to isfile was mentioned previously here: JuliaLang/julia#12819 (comment)

It would also be nice to get a new tagged release as the current one predates the release of 0.4 and is stuffed with deprecation warnings.

Thanks,
Josh

@tkelman
Copy link
Contributor

tkelman commented Feb 10, 2016

readstring needs to use the latest tag of Compat to work on release julia

@jdlangs
Copy link
Contributor Author

jdlangs commented Feb 10, 2016

I don't understand. An unversioned Compat in REQUIRE will not select the most recent version for 0.4?

@tkelman
Copy link
Contributor

tkelman commented Feb 10, 2016

Right but if some other package were to ever put an upper bound on Compat (unlikely but possible), an unversioned requirement would not flag a conflict but would break here. Best to version the lower bound to be on the safe side.

@tkelman
Copy link
Contributor

tkelman commented Feb 11, 2016

The Travis failure is expected since Travis obviously doesn't have Matlab. I adjusted the settings to "only build if .travis.yml is present." We could maybe try something with the redistributable Matlab Compiler Runtime if that could be made to work, but would have to check the license very carefully for whether that's permitted usage.

With a minimum version bound on Compat in REQUIRE I think this would be good to merge.

@jdlangs
Copy link
Contributor Author

jdlangs commented Feb 11, 2016

Fair enough for the versioning. Should be good to go now.

If it's desirable to have more widespread use of Compat versioning, it would probably be good for the docs to mentioned which tag each feature was introduced in.

tkelman added a commit that referenced this pull request Feb 11, 2016
Fix readall and isexecutable deprecations
@tkelman tkelman merged commit cc44a6e into JuliaInterop:master Feb 11, 2016
@tkelman
Copy link
Contributor

tkelman commented Feb 11, 2016

Yes good idea, that's worth a doc issue in Compat.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants