==(DecoratedInterval,Interval) == false, hotfix for #219 #220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpsanders
reviewed
Sep 19, 2018
src/decorations/functions.jl
Outdated
| @@ -33,6 +33,9 @@ end | |||
|
|
|||
| in(x::T, a::DecoratedInterval) where T<:Real = in(x, interval_part(a)) | |||
|
|
|||
| @inline Base.:(==)(xx::DecoratedInterval, yy::Interval) = false | |||
There was a problem hiding this comment.
== should already be imported, so you can just write ==. Inlining should be automatic for a simple function like this I guess.
Codecov Report
@@ Coverage Diff @@
## master #220 +/- ##
==========================================
+ Coverage 97.11% 97.11% +<.01%
==========================================
Files 22 22
Lines 970 972 +2
==========================================
+ Hits 942 944 +2
Misses 28 28
Continue to review full report at Codecov.
|
|
I don't think we want to go in this direction. I would suggest throwing an |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #219.
Added tests so as to not regress coverage, guarantee desired case passes.