Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pow for interval^real and interval^interval #42

Merged
merged 3 commits into from
Jun 11, 2017
Merged

Conversation

dpsanders
Copy link
Member

No description provided.

@codecov-io
Copy link

codecov-io commented May 27, 2017

Codecov Report

Merging #42 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #42      +/-   ##
==========================================
+ Coverage   91.67%   91.69%   +0.01%     
==========================================
  Files          21       21              
  Lines         961      963       +2     
==========================================
+ Hits          881      883       +2     
  Misses         80       80
Impacted Files Coverage Δ
src/intervals/functions.jl 96.15% <100%> (+0.07%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ed8164...40eb21a. Read the comment docs.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 92.199% when pulling a612f79 on pow_for_reals into 0d7f112 on master.

3 similar comments
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 92.199% when pulling a612f79 on pow_for_reals into 0d7f112 on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 92.199% when pulling a612f79 on pow_for_reals into 0d7f112 on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 92.199% when pulling a612f79 on pow_for_reals into 0d7f112 on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 92.199% when pulling a612f79 on pow_for_reals into 0d7f112 on master.

3 similar comments
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 92.199% when pulling a612f79 on pow_for_reals into 0d7f112 on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 92.199% when pulling a612f79 on pow_for_reals into 0d7f112 on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 92.199% when pulling a612f79 on pow_for_reals into 0d7f112 on master.

@lbenet
Copy link
Member

lbenet commented Jun 2, 2017

Tests are missing; otherwise, I think this is ready to be merged.

@dpsanders
Copy link
Member Author

Yes, you're right, it needs tests.

@dpsanders
Copy link
Member Author

Rebased. This is now ready.

@lbenet
Copy link
Member

lbenet commented Jun 11, 2017

Yes, I agree that we should merge this; let's just allow the test to complete. Thanks!

@lbenet
Copy link
Member

lbenet commented Jun 11, 2017

Simple curiosity: have you tried to see how many tests of the ITF1788 pass and how many fail, when using pow as a replacement for ^?

@coveralls
Copy link

coveralls commented Jun 11, 2017

Coverage Status

Coverage increased (+0.02%) to 91.693% when pulling 40eb21a on pow_for_reals into 2ed8164 on master.

@dpsanders
Copy link
Member Author

No I haven't tried, but I expect that almost all will fail...

@dpsanders dpsanders merged commit 73b91d8 into master Jun 11, 2017
@dpsanders dpsanders deleted the pow_for_reals branch August 2, 2017 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants