Basic support for multidimensional IntervalBox's #88
Conversation
|
@lbenet I would like to merge this and tag a new version. Travis on 0.5 is not working for the moment. Is this OK with you? |
|
Sorry, I've been too busy lately. Give me today to take a quick look on this, and if i don't react, just go ahead and merge. |
| @@ -1,5 +1,4 @@ | |||
| julia 0.4 | |||
| FactCheck 0.3 | |||
There was a problem hiding this comment.
Don't we need this here, to point out that the package uses this? I see that it appears in test/REQUIRE, but isn't it necessary here to install it as a dependency when using Pkg.add("ValidatedNumerics")?
There was a problem hiding this comment.
No, it will be installed automatically when Pkg.test is run, and then deleted again. This is the recommended method for test-only dependencies.
There was a problem hiding this comment.
Thanks for commenting on this. I didn't know!
|
I think this is ready. |
|
There are failing tests (julia 0.4); it actually didn't get to the ITF1788 test suite. I'm checking this locally. |
|
They are also failing locally (for both 0.4.4 and 0.5-dev), precisely on "Operations with boxes". |
| import Base: | ||
| ⊆, ∩, isempty | ||
|
|
||
| export IntervalBox |
There was a problem hiding this comment.
IntervalBox is exported in src/ValidatedNumerics.jl; I don't think it needs to be exported here.
|
Sorry, should be OK now. |
|
Tests for Julia 0.4 are passing; so I will merge (in some 15 minutes). I want to see if the tests in 0.5 will finish or not. |
|
I noticed that this PR cannot by merged due to a conflict. Can you solve it? |
|
Finally ready. |
|
Maybe I should squash? |
|
Let's leave this as it is. I'm merging! |
Basic support for multidimensional IntervalBox's
|
It's really a nice PR |
FixedSizeArrays.jlmakes this really easy.