Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CompatHelper: bump compat for HTTP to 1, (keep existing compat) #71

Conversation

github-actions[bot]
Copy link
Contributor

This pull request changes the compat entry for the HTTP package from 0.9 to 0.9, 1.
This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.

@DilumAluthge DilumAluthge force-pushed the compathelper/new_version/2022-06-20-00-20-08-454-03803507606 branch from e6a3420 to fbcd524 Compare June 20, 2022 00:20
@codecov
Copy link

codecov bot commented Jun 20, 2022

Codecov Report

Merging #71 (fbcd524) into master (97143f0) will increase coverage by 1.27%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master      #71      +/-   ##
==========================================
+ Coverage   91.58%   92.85%   +1.27%     
==========================================
  Files          10       10              
  Lines         392      392              
==========================================
+ Hits          359      364       +5     
+ Misses         33       28       -5     
Impacted Files Coverage Δ
src/bump-stdlibs.jl 96.51% <0.00%> (+2.90%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 97143f0...fbcd524. Read the comment docs.

@quinnj
Copy link
Member

quinnj commented Jun 21, 2022

I re-ran the tests here since they needed GitHub.jl to support HTTP.jl 1.0, which it now does. Feel free to merge.

@DilumAluthge DilumAluthge merged commit 9df5d56 into master Jun 21, 2022
@DilumAluthge DilumAluthge deleted the compathelper/new_version/2022-06-20-00-20-08-454-03803507606 branch June 21, 2022 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants