Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

For some stdlibs, it is expected that the stdlib version number won't match the Julia version number #93

Merged
merged 2 commits into from
Aug 28, 2023
Merged

For some stdlibs, it is expected that the stdlib version number won't match the Julia version number #93

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
46bef61
For some stdlibs, it is expected that the stdlib version number won't…
DilumAluthge Aug 25, 2023
4bd5dec
Add DelimitedFiles
DilumAluthge Aug 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 17 additions & 1 deletion src/bump-stdlibs.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,6 +143,22 @@ function _bump_single_stdlib(stdlib::StdlibInfo, config::Config, state::State)
julia_version = Base.VersionNumber(read("VERSION", String))
version_match = stdlib_version isa VersionNumber && Base.thispatch(julia_version) === Base.thispatch(stdlib_version)
url_for_diff = chopsuffix(git_url_markdown, ".git")
# Some external stdlibs intentionally have
# version numbers that don't match the
# Julia version number:
known_rogue_versioners = [
"DelimitedFiles",
"Downloads",
]
if version_match
version_match_statement = ""
else
if stdlib.name in known_rogue_versioners
version_match_statement = "(It's okay that it doesn't match)"
else
version_match_statement = "(Does not match)"
end
end
pr_body_lines = String[
"Stdlib: $(stdlib.name)",
"URL: $(git_url_markdown)",
Expand All @@ -151,7 +167,7 @@ function _bump_single_stdlib(stdlib::StdlibInfo, config::Config, state::State)
"Old commit: $(stdlib_current_commit_in_upstream_short)",
"New commit: $(stdlib_latest_commit_short)",
"Julia version: $(julia_version)",
"$(stdlib.name) version: $(stdlib_version)$(version_match ? "" : " (Does not match)")",
"$(stdlib.name) version: $(stdlib_version)$(version_match_statement)",
"Bump invoked by: $(bumpstdlibs_sender_ping)",
"Powered by: [BumpStdlibs.jl](https://github.com/JuliaLang/BumpStdlibs.jl)",
"",
Expand Down