Add Compat.StringVector #348
Conversation
|
See also JuliaLang/julia#19945 ... it would be nice to decide whether we're actually going to document/export this in Base. |
|
I think we should have this regardless of whether it will be documented/exported in |
|
The 0.4 test is failing because |
|
changing the return type like that seems risky. could this instead wait until Compat drops 0.4 support? |
|
We can also disable that particular test on all versions of 0.4 that have |
README.md
Outdated
| @@ -163,6 +163,8 @@ Currently, the `@compat` macro supports the following syntaxes: | |||
|
|
|||
| * `bswap` is supported for `Complex` arguments on 0.5 and below. ([#21346]) | |||
|
|
|||
| * `Compat.StringVector` is supported on 0.5 and below. ([#19449]) | |||
There was a problem hiding this comment.
Should mention that it is an alias for Base.StringVector on 0.6
src/Compat.jl
Outdated
| @@ -1464,6 +1464,13 @@ if VERSION < v"0.6.0-pre.beta.102" | |||
| Base.bswap(z::Complex) = Complex(bswap(real(z)), bswap(imag(z))) | |||
| end | |||
|
|
|||
| # https://github.com/JuliaLang/julia/pull/19449 | |||
| if VERSION < v"0.6.0-dev.1988" | |||
| StringVector = Vector{UInt8} | |||
There was a problem hiding this comment.
should probably be
StringVector(n::Integer) = Vector{UInt8}(n)
since doing StringVector = Vector{UInt8} has the drawbacks that (a) it is not const and (b) it accepts multiple arguments, unlike Base.StringVector in 0.6.
|
Thanks, I addressed the comments. |
README.md
Outdated
| @@ -163,6 +163,8 @@ Currently, the `@compat` macro supports the following syntaxes: | |||
|
|
|||
| * `bswap` is supported for `Complex` arguments on 0.5 and below. ([#21346]) | |||
|
|
|||
| * `Compat.StringVector` is supported on 0.5 and below. On 0.6 and later, it aliases `Base.StringVector`. ([#19449]) | |||
There was a problem hiding this comment.
Maybe it should suggest using Compat.UTF8String(Compat.StringVector(n)) to create strings from arrays without making copies? This way the code would work on 0.4 too. The test could be modified accordingly.
There was a problem hiding this comment.
0.4 is on its way out, and many users might not know/care about Compat.UTF8String. But you are right about the test. I'll change that.
There was a problem hiding this comment.
Until Compat drops support for 0.4, we should explain how to use it "on 0.5 and below".
There was a problem hiding this comment.
I've updated the README. How's this?
|
The Mac failure is concerning. Does anyone have an idea what's going on? |
|
Although the Travis failure seems to have disappeared overnight, the segfault is still concerning. Should I raise an issue in Base? It may be hard to reproduce. |
|
@stevengj Do you think the current version is good to go? |
* `zeros` and `ones` with interface of `similar` (from #330) * `convert` between `Set` types (from #342) * `isassigned(::RefValue)` (from #345) * `unsafe_trunc(::Type{<:Integer}, ::Integer)` (from #344) * `bswap` for complex numbers (from #346) * Compat.StringVector (from #348) * `invokelatest` (from #352 and #359) * Misc. pre-0.6-only code * obsolete README enries
This is just
Vector{UInt8}on 0.5 and below, andBase.StringVectoron 0.6.