Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: skip wrong host test for SSL_NO_VERIFY (fix #139) #140

Merged
merged 1 commit into from
Aug 19, 2021

Commits on Aug 19, 2021

  1. tests: skip wrong host test for SSL_NO_VERIFY (fix #139)

    Since #114, we only turn
    off peer verification, not host verification when the `SSL_NO_VERIFY`
    variables are set. This means that the last set of tests in the "SSL no
    verify override" testset *should* fail for `wrong.host.badssl.com`. That
    is not what I was seeing, however — the test was still passing — which I
    found puzzling but just moved on with my life at the time. It turns out
    that the test *does* fail if libcurl is build with OpenSSL. Since
    whether the test passes or not for that host depends on how things are
    built, this change simply skips the test (by popping the URL from the
    set of tested URLS for that testset).
    
    The tests above that which use the easy hook mechanism are fixed in a
    different way: for those I made the hook disable both host and peer
    verification, which should fix the tests for any bad host including when
    the server sends the wrong host name.
    StefanKarpinski committed Aug 19, 2021
    Configuration menu
    Copy the full SHA
    7020db8 View commit details
    Browse the repository at this point in the history