-
-
Notifications
You must be signed in to change notification settings - Fork 656
Register new package IOLogging.jl v0.1.0 #18063
Conversation
That JuliaCIBot failure seems unrelated to my package - right? |
Well, I wouldn't call it unrelated as your package somehow manages to trigger a bug in Pkg. Unfortunately, we probably have to wait with merging this PR until we understand the bug since there is a risk that it would break the resolver. |
This is caused by julia> Pkg.Types.semver_spec(">=0.7, ^1")
ERROR: type VersionBound has no field lo
Stacktrace:
[1] getproperty(::Any, ::Symbol) at ./sysimg.jl:18
[2] isjoinable(::Pkg.Types.VersionBound, ::Pkg.Types.VersionBound) at /Users/osx/buildbot/slave/package_osx64/build/usr/share/julia/stdlib/v1.0/Pkg/src/versions.jl:69
[3] union!(::Array{Pkg.Types.VersionRange,1}) at /Users/osx/buildbot/slave/package_osx64/build/usr/share/julia/stdlib/v1.0/Pkg/src/versions.jl:159
[4] Type at /Users/osx/buildbot/slave/package_osx64/build/usr/share/julia/stdlib/v1.0/Pkg/src/versions.jl:183 [inlined]
[5] semver_spec(::String) at /Users/osx/buildbot/slave/package_osx64/build/usr/share/julia/stdlib/v1.0/Pkg/src/versions.jl:268
[6] top-level scope at none:0 cc: @KristofferC |
Oh boy! Just FYI, I added this spec to make sure it wouldn't be installed on anything after 1.x, since the logging interface could change a bit. |
I think this is indicative of more than just that - shouldn't this:
give |
Yes. That doesn't look right. Would be great if you could report that as a separate issue at https://github.com/JuliaLang/Pkg.jl/issues |
Done! I guess I can change the version spec to |
The project file won't be used in the conversion anyways, so what matters is what you have in REQUIRE |
I'll recommend that you just set |
I've changed both REQUIRE and Project.toml to no longer specify an upperbound for the package. |
5cafabb
to
4d077cb
Compare
Repository: Seelengrab/IOLogging.jl Please make sure that:
@Seelengrab This PR will remain open for three days for feedback (which is optional). If you get feedback, please let us know if you are making changes, and we'll merge once you're done. |
Repository: Seelengrab/IOLogging.jl
Release: v0.1.0
cc: @Seelengrab
Please make sure that:
@Seelengrab This PR will remain open for three days for feedback (which is optional). If you get feedback, please let us know if you are making changes, and we'll merge once you're done.