Skip to content
This repository has been archived by the owner on Aug 12, 2022. It is now read-only.

Register new package IOLogging.jl v0.1.0 #18063

Merged
merged 1 commit into from
Sep 20, 2018

Conversation

attobot
Copy link
Contributor

@attobot attobot commented Sep 17, 2018

Repository: Seelengrab/IOLogging.jl
Release: v0.1.0
cc: @Seelengrab

Please make sure that:

  • CI passes for supported Julia versions (if applicable).
  • Version bounds reflect minimum requirements.

@Seelengrab This PR will remain open for three days for feedback (which is optional). If you get feedback, please let us know if you are making changes, and we'll merge once you're done.

@Seelengrab
Copy link

That JuliaCIBot failure seems unrelated to my package - right?

@andreasnoack
Copy link
Member

Well, I wouldn't call it unrelated as your package somehow manages to trigger a bug in Pkg. Unfortunately, we probably have to wait with merging this PR until we understand the bug since there is a risk that it would break the resolver.

Ref JuliaLang/Pkg.jl#750

@andreasnoack
Copy link
Member

This is caused by

julia> Pkg.Types.semver_spec(">=0.7, ^1")
ERROR: type VersionBound has no field lo
Stacktrace:
 [1] getproperty(::Any, ::Symbol) at ./sysimg.jl:18
 [2] isjoinable(::Pkg.Types.VersionBound, ::Pkg.Types.VersionBound) at /Users/osx/buildbot/slave/package_osx64/build/usr/share/julia/stdlib/v1.0/Pkg/src/versions.jl:69
 [3] union!(::Array{Pkg.Types.VersionRange,1}) at /Users/osx/buildbot/slave/package_osx64/build/usr/share/julia/stdlib/v1.0/Pkg/src/versions.jl:159
 [4] Type at /Users/osx/buildbot/slave/package_osx64/build/usr/share/julia/stdlib/v1.0/Pkg/src/versions.jl:183 [inlined]
 [5] semver_spec(::String) at /Users/osx/buildbot/slave/package_osx64/build/usr/share/julia/stdlib/v1.0/Pkg/src/versions.jl:268
 [6] top-level scope at none:0

cc: @KristofferC

@Seelengrab
Copy link

Oh boy! Just FYI, I added this spec to make sure it wouldn't be installed on anything after 1.x, since the logging interface could change a bit.

@Seelengrab
Copy link

Seelengrab commented Sep 17, 2018

I think this is indicative of more than just that - shouldn't this:

julia> Pkg.Types.semver_spec(">=0.7, ^0")
VersionSpec("0.0.0-*")

give VersionSpec("0.7.0-0.*")? And the original spec should give VersionSpec("0.7.0-1.*"), if I understand correctly (Ref. this discussion on discourse).

@andreasnoack
Copy link
Member

Yes. That doesn't look right. Would be great if you could report that as a separate issue at https://github.com/JuliaLang/Pkg.jl/issues

@Seelengrab
Copy link

Seelengrab commented Sep 17, 2018

Done!

I guess I can change the version spec to julia = "0.7" for now? Not ideal though.

@fredrikekre
Copy link
Member

The project file won't be used in the conversion anyways, so what matters is what you have in REQUIRE

@andreasnoack
Copy link
Member

I'll recommend that you just set julia = ">=0.7 for now and then adjust this once Pkg has been updated.

@Seelengrab
Copy link

Seelengrab commented Sep 19, 2018

I've changed both REQUIRE and Project.toml to no longer specify an upperbound for the package. Is it possible to rerun JuliaCIBot and your travis to confirm this? Nevermind, I remembered about the functionality of attobot.

@attobot
Copy link
Contributor Author

attobot commented Sep 19, 2018

Repository: Seelengrab/IOLogging.jl
Release: v0.1.0
cc: @Seelengrab

Please make sure that:

  • CI passes for supported Julia versions (if applicable).
  • Version bounds reflect minimum requirements.

@Seelengrab This PR will remain open for three days for feedback (which is optional). If you get feedback, please let us know if you are making changes, and we'll merge once you're done.

@andreasnoack andreasnoack merged commit 27f9e7f into JuliaLang:metadata-v2 Sep 20, 2018
@attobot attobot deleted the IOLogging/v0.1.0 branch September 20, 2018 07:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants