fixes

JuliaLang · Jul 5, 2023 · 94a6a65 · 94a6a65
1 parent e2ce61e
commit 94a6a65
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/src/GitTools.jl b/src/GitTools.jl
@@ -109,8 +109,8 @@ function clone(io::IO, url, source_path; header=nothing, credentials=nothing, kw
     end
     try
         if use_cli_git()
+            cmd = `git clone --quiet $url $source_path`
             try
-                cmd = `git clone --quiet $url $source_path`
                 run(pipeline(cmd; stdout=devnull))
             catch err
                 Pkg.Types.pkgerror("The command `$(cmd)` failed, error: $err")
@@ -166,8 +166,8 @@ function fetch(io::IO, repo::LibGit2.GitRepo, remoteurl=nothing; header=nothing,
         if use_cli_git()
             let remoteurl=remoteurl
                 cd(LibGit2.path(repo)) do
+                    cmd = `git fetch -q $remoteurl $(only(refspecs))`
                     try
-                        cmd = `git fetch -q $remoteurl $(only(refspecs))`
                         run(pipeline(cmd; stdout=devnull))
                     catch err
                         Pkg.Types.pkgerror("The command `$(cmd)` failed, error: $err")

diff --git a/test/new.jl b/test/new.jl
@@ -2705,8 +2705,8 @@ end
                     Pkg.rm(TEST_PKG.name)
                 end
                 @testset "libgit2 failures" begin
-                    doesnotexist = "https:://github.com/DoesNotExist/DoesNotExist.jl"
-                    @test_throws Pkg.Types.PkgError Pkg.add(url=doesnotexist; use_git_for_all_downloads=true)
+                    doesnotexist = "https://github.com/DoesNotExist/DoesNotExist.jl"
+                    @test_throws Pkg.Types.PkgError Pkg.add(url=doesnotexist, use_git_for_all_downloads=true)
                     @test_throws Pkg.Types.PkgError Pkg.Registry.add(RegistrySpec(url=doesnotexist); use_git_for_all_downloads=true)
                 end
                 @testset "tarball downloads" begin