Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downloads trailing task warning during precompilation on 1.11rc2 and 1.11rc3 #4004

Closed
ufechner7 opened this issue Aug 24, 2024 · 15 comments · Fixed by JuliaLang/Downloads.jl#257

Comments

@ufechner7
Copy link
Contributor

julia> versioninfo()
Julia Version 1.11.0-rc2
Commit 34c3a63147b (2024-07-29 06:24 UTC)
Build Info:
  Official https://julialang.org/ release
Platform Info:
  OS: Linux (x86_64-linux-gnu)
  CPU: 16 × AMD Ryzen 7 7840U w/ Radeon  780M Graphics
  WORD_SIZE: 64
  LLVM: libLLVM-16.0.6 (ORCJIT, znver4)
Threads: 1 default, 0 interactive, 1 GC (on 16 virtual cores)

Test script:

#!/bin/bash -eu
rm -rf /tmp/testdepot
mkdir /tmp/testdepot
rm -rf /tmp/test
mkdir /tmp/test
cd /tmp/test
export JULIA_DEPOT_PATH=/tmp/testdepot 
julia --project="." -e "using Pkg; Pkg.add(\"LinearSolve\"); using LinearSolve"
cd ..

Output:

       Info Packages marked with ⌅ have new versions available but compatibility constraints restrict them from upgrading. To see why use `status --outdated -m`
Precompiling project...
  104 dependencies successfully precompiled in 67 seconds. 21 already precompiled.
  1 dependency had output during precompilation:
┌ MKL_jll
│   Downloading artifact: MKL
│  
│  [pid 29931] waiting for IO to finish:
│   Handle type        uv_handle_t->data
│   timer              0x591eb7b98610->0x7029f5fa8670
│  This means that a package has started a background task or event source that has not finished running. For precompilation to complete successfully, the event source needs to be closed explicitly. See the developer documentation on fixing precompilation hangs for more help.
│  
│  [pid 29931] waiting for IO to finish:
│   Handle type        uv_handle_t->data
│   timer              0x591eb7b98610->0x7029f5fa8670
│  This means that a package has started a background task or event source that has not finished running. For precompilation to complete successfully, the event source needs to be closed explicitly. See the developer documentation on fixing precompilation hangs for more help.

This issue does also appear with Julia 1.10.4, but is fixed in the release-1.10 branch.
It is a Pkg issue.

@ufechner7
Copy link
Contributor Author

ufechner7 commented Aug 24, 2024

See also: #3950

The comment "is alrady fixed in 1.11" is wrong.

@jishnub
Copy link
Contributor

jishnub commented Aug 24, 2024

This should probably be moved to the Pkg.jl repo?

@ufechner7
Copy link
Contributor Author

This should probably be moved to the Pkg.jl repo?

Who could do that? I would not know how to do that.

@jishnub
Copy link
Contributor

jishnub commented Aug 24, 2024

Some admin of the org. Either way, I'll not worry about it, as it'll reach the right eyes. The Pkg repo has less activity, so the issue is less likely to be lost.

@giordano
Copy link
Contributor

Some admin of the org.

You can also do it by clicking on the "transfer issue" button on the right sidebar

@jishnub jishnub transferred this issue from JuliaLang/julia Aug 24, 2024
@ufechner7 ufechner7 changed the title Precompliation warning on 1.11rc2 Precompliation warning on 1.11rc2 and 1.11rc3 Aug 27, 2024
@ufechner7
Copy link
Contributor Author

Same problem on Julia 1.11rc3. Can this be added to the 1.11 milestone?

@giordano
Copy link
Contributor

giordano commented Aug 27, 2024

Why? It has been there forever, why it should suddenly become a release blocker?

@IanButterworth IanButterworth changed the title Precompliation warning on 1.11rc2 and 1.11rc3 Downloads trailing task warning during precompilation on 1.11rc2 and 1.11rc3 Aug 28, 2024
@IanButterworth
Copy link
Sponsor Member

IanButterworth commented Aug 28, 2024

Can someone with an intel cpu check whether this reproduces on nightly julia?

% JULIA_DEPOT_PATH=$(mktemp -d): julia +1.11 --start=no -e 'using Pkg; Pkg.add("LinearSolve"); using LinearSolve'

@jishnub
Copy link
Contributor

jishnub commented Aug 28, 2024

Output on nightly v"1.12.0-DEV.1106" using

JULIA_DEPOT_PATH=$(mktemp -d): julia +nightly --startup=no -e 'using Pkg; Pkg.add("LinearSolve"); using LinearSolve'
[...]
Precompiling all packages...
  95 dependencies successfully precompiled in 108 seconds. 33 already precompiled.
  1 dependency had output during precompilation:
┌ MKL_jll
│   Downloading artifact: MKL
│  
│  [pid 46097] waiting for IO to finish:
│   Handle type        uv_handle_t->data
│   timer              0x196ea00->0x752a7a1aad10
│  This means that a package has started a background task or event source that has not finished running. For precompilation to complete successfully, the event source needs to be closed explicitly. See the developer documentation on fixing precompilation hangs for more help.
│  
│  [pid 46097] waiting for IO to finish:
│   Handle type        uv_handle_t->data
│   timer              0x196ea00->0x752a7a1aad10
│  This means that a package has started a background task or event source that has not finished running. For precompilation to complete successfully, the event source needs to be closed explicitly. See the developer documentation on fixing precompilation hangs for more help.
└  

versioninfo:

julia> versioninfo()
Julia Version 1.10.4
Commit 48d4fd48430 (2024-06-04 10:41 UTC)
Build Info:
  Official https://julialang.org/ release
Platform Info:
  OS: Linux (x86_64-linux-gnu)
  CPU: 12 × Intel(R) Core(TM) i7-10750H CPU @ 2.60GHz
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-15.0.7 (ORCJIT, skylake)
Threads: 1 default, 0 interactive, 1 GC (on 12 virtual cores)
Environment:
  JULIA_EDITOR = subl

@ufechner7
Copy link
Contributor Author

Why? It has been there forever, why it should suddenly become a release blocker?

Because it is fixed in Julia 1.10.5

@IanButterworth
Copy link
Sponsor Member

@jishnub seems you're on 1.10.4?

julia> versioninfo()
Julia Version 1.10.4

@jishnub
Copy link
Contributor

jishnub commented Aug 28, 2024

That's just for the versioninfo which I generated separately, mainly for the CPU info

@IanButterworth
Copy link
Sponsor Member

Ok, please update it for clarity. The commit info is helpful.

@IanButterworth
Copy link
Sponsor Member

For anyone trying to repro this, this works for all architectures, not just intel.

% JULIA_DEPOT_PATH=$(mktemp -d): julia +1.11 --start=no -e 'using Pkg; Pkg.add("MicroMamba");'

I'm looking into what's happening here.

@IanButterworth
Copy link
Sponsor Member

Found the issue. The Downloads atexit tidy up function was only being registered when precompiling Downloads itself, which meant the test case in Downloads was fixed but not in any packages that use Downloads. JuliaLang/Downloads.jl#257

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants