Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.10] Fix the trailing task warning on lazy artifacts #3950

Merged
merged 2 commits into from
Jul 13, 2024

Conversation

IanButterworth
Copy link
Sponsor Member

Fixes the issue where downloading i.e. MKL during precompilation causes the trailing task warning.

It's already fixed on 1.11+ because finalizers (the global Downloader finalizer) runs before the trailing task detector on 1.11+

@IanButterworth IanButterworth changed the title [release-1.10] Fix the trailing task warning on lazy artifacts [backports-release-1.10] Fix the trailing task warning on lazy artifacts Jul 13, 2024
src/PlatformEngines.jl Outdated Show resolved Hide resolved
Base automatically changed from backports-release-1.10 to release-1.10 July 13, 2024 12:01
An error occurred while trying to automatically change base from backports-release-1.10 to release-1.10 July 13, 2024 12:01
@IanButterworth IanButterworth changed the title [backports-release-1.10] Fix the trailing task warning on lazy artifacts [release-1.10] Fix the trailing task warning on lazy artifacts Jul 13, 2024
@IanButterworth
Copy link
Sponsor Member Author

Confirmed to fix the issue (on a linux system)

$ JULIA_DEPOT_PATH=$(mktemp -d) ./julia -e 'using Pkg; Pkg.add(name="CUDA_Driver_jll", version="0.9.0")'                                            
  Installing known registries into `/tmp/tmp.cbXhw2NPkR`                                                                                                                         
    Updating registry at `/tmp/tmp.cbXhw2NPkR/registries/General.toml`                                                                                                           
   Resolving package versions...                                                                                                                                                 
   Installed JLLWrappers ───── v1.5.0                                                                                                                                            
   Installed Preferences ───── v1.4.3                                                                                                                                            
   Installed CUDA_Driver_jll ─ v0.9.0+0                                                                                                                                          
    Updating `/tmp/tmp.cbXhw2NPkR/environments/v1.10/Project.toml`
⌃ [4ee394cb] + CUDA_Driver_jll v0.9.0+0
    Updating `/tmp/tmp.cbXhw2NPkR/environments/v1.10/Manifest.toml`
  [692b3bcd] + JLLWrappers v1.5.0
  [21216c6a] + Preferences v1.4.3
⌃ [4ee394cb] + CUDA_Driver_jll v0.9.0+0
  [0dad84c5] + ArgTools v1.1.1
  [56f22d72] + Artifacts
  [2a0f44e3] + Base64
  [ade2ca70] + Dates
  [f43a241f] + Downloads v1.6.0
  [7b1f6079] + FileWatching
  [b77e0a4c] + InteractiveUtils
  [4af54fe1] + LazyArtifacts
  [b27032c2] + LibCURL v0.6.4
  [76f85450] + LibGit2
  [8f399da3] + Libdl
  [56ddb016] + Logging
  [d6f4376e] + Markdown
  [ca575930] + NetworkOptions v1.2.0
  [44cfe95a] + Pkg v1.10.0
  [de0858da] + Printf
  [3fa0cd96] + REPL
  [9a3f8284] + Random
  [ea8e919c] + SHA v0.7.0
  [9e88b42a] + Serialization
  [6462fe0b] + Sockets
  [fa267f1f] + TOML v1.0.3
  [a4e569a6] + Tar v1.10.0
  [cf7118a7] + UUIDs
  [4ec0a83e] + Unicode
  [deac9b47] + LibCURL_jll v8.4.0+0
  [e37daf67] + LibGit2_jll v1.6.4+0
  [29816b5a] + LibSSH2_jll v1.11.0+1
  [c8ffd9c3] + MbedTLS_jll v2.28.2+1
  [14a3606d] + MozillaCACerts_jll v2023.1.10
  [83775a58] + Zlib_jll v1.2.13+1
  [8e850ede] + nghttp2_jll v1.52.0+1
  [3f19e933] + p7zip_jll v17.4.0+2
        Info Packages marked with ⌃ have new versions available and may be upgradable.
Precompiling project...
  5 dependencies successfully precompiled in 10 seconds
  1 dependency had output during precompilation:
┌ CUDA_Driver_jll
│   Downloading artifact: CUDA_Driver
└  

@IanButterworth IanButterworth merged commit 6d73ac1 into release-1.10 Jul 13, 2024
12 of 13 checks passed
@IanButterworth IanButterworth deleted the ib/lazy_artifacts_downloader branch July 13, 2024 12:41
@GunnarFarneback
Copy link
Contributor

Where is this issue discussed for 1.11+? I can confirm that this test case works on a Linux source build of the 1.10 branch but both 1.11.0-rc2 and 1.12.0-DEV.1085 (2024-08-23) from juliaup still give the warning.

@IanButterworth
Copy link
Sponsor Member Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants