handle git cli errors as pkgerrors #3538

IanButterworth · 2023-07-04T10:55:35Z

Without this if you're offline and using the git cli

(Pkg) pkg> up
┌ Warning: could not download https://pkg.julialang.org/registries
│   exception = RequestError: Could not resolve host: pkg.julialang.org while requesting https://pkg.julialang.org/registries
└ @ Pkg.Registry ~/Documents/GitHub/julia/usr/share/julia/stdlib/v1.11/Pkg/src/Registry/Registry.jl:69
    Updating registry at `~/.julia/registries/HolyLabRegistry`
    Updating git-repo `[email protected]:HolyLab/HolyLabRegistry`
ssh: connect to host github.com port 22: Undefined error: 0
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.
ERROR: failed process: Process(`git fetch -q [email protected]:HolyLab/HolyLabRegistry +refs/heads/master:refs/remotes/origin/master`, ProcessExited(128)) [128]

Stacktrace:
  [1] pipeline_error(proc::Base.Process)
    @ Base ./process.jl:565 [inlined]
  [2] run(::Base.CmdRedirect; wait::Bool)
    @ Base ./process.jl:480
  [3] run(::Base.CmdRedirect)
    @ Base ./process.jl:477 [inlined]
  [4] (::Pkg.GitTools.var"#6#8"{Vector{String}, SubString{String}})()
    @ Pkg.GitTools ~/Documents/GitHub/julia/usr/share/julia/stdlib/v1.11/Pkg/src/GitTools.jl:164
  [5] cd(f::Pkg.GitTools.var"#6#8"{Vector{String}, SubString{String}}, dir::String)
    @ Base.Filesystem ./file.jl:112
  [6] fetch(io::Base.TTY, repo::LibGit2.GitRepo, remoteurl::Nothing; header::Nothing, credentials::Nothing, refspecs::Vector{String}, kwargs::@Kwargs{})
    @ Pkg.GitTools ~/Documents/GitHub/julia/usr/share/julia/stdlib/v1.11/Pkg/src/GitTools.jl:163
  [7] kwcall(::NamedTuple, ::typeof(Pkg.GitTools.fetch), io::IO, repo::LibGit2.GitRepo) (repeats 2 times)
    @ Pkg.GitTools ~/Documents/GitHub/julia/usr/share/julia/stdlib/v1.11/Pkg/src/GitTools.jl:135 [inlined]
  [8] (::Pkg.Registry.var"#77#82"{Pkg.Registry.RegistryInstance, Vector{Tuple{String, String}}, String, Base.TTY, Dict{String, Any}})(repo::LibGit2.GitRepo)
    @ Pkg.Registry ~/Documents/GitHub/julia/usr/share/julia/stdlib/v1.11/Pkg/src/Registry/Registry.jl:464
  [9] with(f::Pkg.Registry.var"#77#82"{Pkg.Registry.RegistryInstance, Vector{Tuple{String, String}}, String, Base.TTY, Dict{String, Any}}, obj::LibGit2.GitRepo)
    @ LibGit2 ~/Documents/GitHub/julia/usr/share/julia/stdlib/v1.11/LibGit2/src/types.jl:1160
 [10] (::Pkg.Registry.var"#73#78"{Base.TTY, Dates.Day, Dict{String, Any}, String, Vector{Pkg.Registry.RegistryInstance}})()
    @ Pkg.Registry ~/Documents/GitHub/julia/usr/share/julia/stdlib/v1.11/Pkg/src/Registry/Registry.jl:449
 [11] mkpidlock(f::Pkg.Registry.var"#73#78"{Base.TTY, Dates.Day, Dict{…}, String, Vector{…}}, at::String, pid::Int32; kwopts::@Kwargs{stale_age::Int64})
    @ FileWatching.Pidfile ~/Documents/GitHub/julia/usr/share/julia/stdlib/v1.11/FileWatching/src/pidfile.jl:92
 [12] mkpidlock(f::Pkg.Registry.var"#73#78"{Base.TTY, Dates.Day, Dict{String, Any}, String}, at::String; kwopts::@Kwargs{stale_age::Int64})
    @ FileWatching.Pidfile ~/Documents/GitHub/julia/usr/share/julia/stdlib/v1.11/FileWatching/src/pidfile.jl:87 [inlined]
 [13] mkpidlock
    @ FileWatching.Pidfile ~/Documents/GitHub/julia/usr/share/julia/stdlib/v1.11/FileWatching/src/pidfile.jl:87 [inlined]
 [14] update(regs::Vector{Pkg.Registry.RegistrySpec}; io::Base.TTY, force::Bool, depots::Vector{String}, update_cooldown::Dates.Day)
    @ Pkg.Registry ~/Documents/GitHub/julia/usr/share/julia/stdlib/v1.11/Pkg/src/Registry/Registry.jl:379
 [15] update_registries(ctx::Pkg.Types.Context; force::Bool, kwargs::@Kwargs{update_cooldown::Dates.Day})
    @ Pkg.Operations ~/Documents/GitHub/julia/usr/share/julia/stdlib/v1.11/Pkg/src/Operations.jl:1266
 [16] add(ctx::Pkg.Types.Context, pkgs::Vector{…}; preserve::Pkg.Types.PreserveLevel, platform::Base.BinaryPlatforms.Platform, kwargs::@Kwargs{…})
    @ Pkg.API ~/Documents/GitHub/julia/usr/share/julia/stdlib/v1.11/Pkg/src/API.jl:262
 [17] add(pkgs::Vector{Pkg.Types.PackageSpec}; io::Base.TTY, kwargs::@Kwargs{})
    @ Pkg.API ~/Documents/GitHub/julia/usr/share/julia/stdlib/v1.11/Pkg/src/API.jl:159
 [18] add(pkgs::Vector{Pkg.Types.PackageSpec})
    @ Pkg.API ~/Documents/GitHub/julia/usr/share/julia/stdlib/v1.11/Pkg/src/API.jl:148
 [19] add(pkgs::Vector{String}; kwargs::@Kwargs{})
    @ Pkg.API ~/Documents/GitHub/julia/usr/share/julia/stdlib/v1.11/Pkg/src/API.jl:147 [inlined]
 [20] add
    @ Pkg.API ~/Documents/GitHub/julia/usr/share/julia/stdlib/v1.11/Pkg/src/API.jl:147 [inlined]
 [21] try_prompt_pkg_add(pkgs::Vector{Symbol})
    @ Pkg.REPLMode ~/Documents/GitHub/julia/usr/share/julia/stdlib/v1.11/Pkg/src/REPLMode/REPLMode.jl:729
 [22] invokelatest(f::Any, args::Vector{Symbol}; kwargs::@Kwargs{})
    @ Base ./essentials.jl:867 [inlined]
 [23] invokelatest(f::Any, args::Vector{Symbol})
    @ Base ./essentials.jl:864 [inlined]
 [24] check_for_missing_packages_and_run_hooks(ast::Any)
    @ REPL ~/Documents/GitHub/julia/usr/share/julia/stdlib/v1.11/REPL/src/REPL.jl:174
 [25] eval_user_input(ast::Any, backend::REPL.REPLBackend, mod::Module)
    @ REPL ~/Documents/GitHub/julia/usr/share/julia/stdlib/v1.11/REPL/src/REPL.jl:145
 [26] repl_backend_loop(backend::REPL.REPLBackend, get_module::Function)
    @ REPL ~/Documents/GitHub/julia/usr/share/julia/stdlib/v1.11/REPL/src/REPL.jl:246
 [27] start_repl_backend(backend::REPL.REPLBackend, consumer::Any; get_module::Function)
    @ REPL ~/Documents/GitHub/julia/usr/share/julia/stdlib/v1.11/REPL/src/REPL.jl:231
 [28] run_repl(repl::REPL.AbstractREPL, consumer::Any; backend_on_current_task::Bool, backend::Any)
    @ REPL ~/Documents/GitHub/julia/usr/share/julia/stdlib/v1.11/REPL/src/REPL.jl:376
 [29] run_repl(repl::REPL.AbstractREPL, consumer::Any)
    @ REPL ~/Documents/GitHub/julia/usr/share/julia/stdlib/v1.11/REPL/src/REPL.jl:362
 [30] (::Base.var"#1010#1012"{Bool, Bool, Bool})(REPL::Module)
    @ Base ./client.jl:432
 [31] invokelatest(::typeof(Base.CoreLogging.handle_message), ::Base.CoreLogging.AbstractLogger, ::Base.CoreLogging.LogLevel, ::String, ::Module, ::Symbol, ::Symbol, ::String, ::Int64; kwargs::@Kwargs{})
    @ Base ./essentials.jl:867 [inlined]
 [32] invokelatest(f::Base.var"#1010#1012"{Bool, Bool, Bool}, args::Module)
    @ Base ./essentials.jl:864 [inlined]
 [33] run_main_repl(interactive::Bool, quiet::Bool, banner::Bool, history_file::Bool, color_set::Bool)
    @ Base ./client.jl:416
 [34] exec_options(opts::Base.JLOptions)
    @ Base ./client.jl:333
 [35] _start()
    @ Base ./client.jl:552
Some type information was truncated. Use `show(err)` to see complete types.

(Pkg) pkg>

With this PR

(Pkg) pkg> up
┌ Warning: could not download https://pkg.julialang.org/registries
│   exception = RequestError: Could not resolve host: pkg.julialang.org while requesting https://pkg.julialang.org/registries
└ @ Pkg.Registry ~/Documents/GitHub/Pkg.jl/src/Registry/Registry.jl:69
    Updating registry at `~/.julia/registries/HolyLabRegistry`
    Updating git-repo `[email protected]:HolyLab/HolyLabRegistry`
ssh: connect to host github.com port 22: Undefined error: 0
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.
    Updating registry at `~/.julia/registries/General.toml`
┌ Error: Some registries failed to update:
│     — /Users/ian/.julia/registries/HolyLabRegistry — failed to fetch from repo: Git cli failed to fetch repository at '[email protected]:HolyLab/HolyLabRegistry'
│ error: ProcessFailedException(Base.Process[Process(`git fetch -q [email protected]:HolyLab/HolyLabRegistry +refs/heads/master:refs/remotes/origin/master`, ProcessExited(128))])
└ @ Pkg.Registry ~/Documents/GitHub/Pkg.jl/src/Registry/Registry.jl:510
  No Changes to `~/Documents/GitHub/Pkg.jl/Project.toml`
  No Changes to `~/Documents/GitHub/Pkg.jl/Manifest.toml`

(Pkg) pkg>

The

ssh: connect to host github.com port 22: Undefined error: 0
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.

is a little untidy but I thought it best to not capture stderr in case the git cli is asking the user for user credentials etc.

src/GitTools.jl

Co-Authored-By: Fredrik Ekre <[email protected]>

IanButterworth · 2023-07-09T16:40:07Z

Any idea why this broke windows? Seems like it's waiting on input or something now

Revert "debug - run CI with logs on" This reverts commit a8f8125. Update test.yml

fredrikekre · 2023-07-10T21:00:10Z

.github/workflows/test.yml

@@ -61,7 +61,7 @@ jobs:
      - run: julia --project --color=yes --check-bounds=yes -e 'import Pkg; Pkg.build(); Pkg.test(; coverage=true)'
        env:
          JULIA_PKG_SERVER: ${{ matrix.pkg-server }}
-          JULIA_PKG_TEST_QUIET: "true" # "true" is the default. i.e. tests are quiet when this env var isn't set
+          JULIA_PKG_TEST_QUIET: "false" # "true" is the default. i.e. tests are quiet when this env var isn't set


Should this be reverted for the merge?

Yeah. Converted to draft

IanButterworth · 2023-07-10T21:01:31Z

It seems like the git cli on the Windows CI machines is interactively requesting creds or something from the user for a simple Pkg.add(url="https://github.com/JuliaLang/Example.jl"), and that seems to have not been tested prior to this PR.

Anyone know how to fix it?

IanButterworth · 2023-07-17T00:31:46Z

Ok. I've just avoided extending the tests to Windows, with TODOs

(cherry picked from commit b612bfd)

IanButterworth added backport 1.9 backport 1.10 labels Jul 4, 2023

fredrikekre reviewed Jul 5, 2023

View reviewed changes

src/GitTools.jl Outdated Show resolved Hide resolved

handle git cli errors as pkgerrors

ae84218

Co-Authored-By: Fredrik Ekre <[email protected]>

IanButterworth force-pushed the ib/git_cli_err_handle branch from 5623a65 to ae84218 Compare July 5, 2023 22:35

Merge branch 'master' into ib/git_cli_err_handle

728f3cb

IanButterworth added the merge me Merge when tests pass label Jul 8, 2023

Merge branch 'master' into ib/git_cli_err_handle

3a7cf10

debug - run CI with logs on

94b1907

Revert "debug - run CI with logs on" This reverts commit a8f8125. Update test.yml

IanButterworth requested a review from a team as a code owner July 10, 2023 14:44

test add Example via url (and tidy up dup tests)

3a78e47

DilumAluthge removed the request for review from a team July 10, 2023 17:28

fixes & test tidy

d2df396

IanButterworth removed the merge me Merge when tests pass label Jul 10, 2023

fredrikekre approved these changes Jul 10, 2023

View reviewed changes

IanButterworth marked this pull request as draft July 10, 2023 21:01

IanButterworth added 5 commits July 10, 2023 17:03

fix testset name

e1691aa

set GIT_TERMINAL_PROMPT = 0

3acfb98

don't test git cli with urls on windows

eb18656

fixes

d480065

more fix

3970277

IanButterworth marked this pull request as ready for review July 17, 2023 11:55

IanButterworth merged commit b612bfd into JuliaLang:master Jul 17, 2023
13 checks passed

IanButterworth deleted the ib/git_cli_err_handle branch August 16, 2023 20:53

IanButterworth added a commit that referenced this pull request Aug 18, 2023

handle git cli errors as pkgerrors (#3538)

376a295

(cherry picked from commit b612bfd)

IanButterworth added a commit that referenced this pull request Aug 18, 2023

handle git cli errors as pkgerrors (#3538)

b9141b9

(cherry picked from commit b612bfd)

IanButterworth mentioned this pull request Aug 18, 2023

Backports release 1.9 #3595

Merged

10 tasks

IanButterworth added a commit that referenced this pull request Aug 18, 2023

handle git cli errors as pkgerrors (#3538)

b0a52a7

(cherry picked from commit b612bfd)

IanButterworth mentioned this pull request Aug 18, 2023

Backports release 1.10 #3596

Merged

14 tasks

IanButterworth added a commit that referenced this pull request Aug 18, 2023

handle git cli errors as pkgerrors (#3538)

d0d5dda

IanButterworth removed backport 1.9 backport 1.10 labels Aug 19, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

handle git cli errors as pkgerrors #3538

handle git cli errors as pkgerrors #3538

IanButterworth commented Jul 4, 2023 •

edited

Loading

IanButterworth commented Jul 9, 2023

fredrikekre Jul 10, 2023

IanButterworth Jul 10, 2023

IanButterworth commented Jul 10, 2023

IanButterworth commented Jul 17, 2023

handle git cli errors as pkgerrors #3538

handle git cli errors as pkgerrors #3538

Conversation

IanButterworth commented Jul 4, 2023 • edited Loading

IanButterworth commented Jul 9, 2023

fredrikekre Jul 10, 2023

Choose a reason for hiding this comment

IanButterworth Jul 10, 2023

Choose a reason for hiding this comment

IanButterworth commented Jul 10, 2023

IanButterworth commented Jul 17, 2023

IanButterworth commented Jul 4, 2023 •

edited

Loading