Skip to content

Commit

Permalink
inference: ignore badly behaving generated functions (#36115)
Browse files Browse the repository at this point in the history
fix #36088
  • Loading branch information
vtjnash authored Jun 3, 2020
1 parent a1b6d7d commit 5d6a910
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions base/compiler/abstractinterpretation.jl
Original file line number Diff line number Diff line change
Expand Up @@ -263,6 +263,7 @@ function abstract_call_method_with_const_args(interp::AbstractInterpreter, @nosp
if inf_result === nothing
inf_result = InferenceResult(mi, argtypes)
frame = InferenceState(inf_result, #=cache=#false, interp)
frame === nothing && return Any # this is probably a bad generated function (unsound), but just ignore it
frame.limited = true
frame.parent = sv
push!(inf_cache, inf_result)
Expand Down

2 comments on commit 5d6a910

@nanosoldier
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Executing the daily benchmark build, I will reply here when finished:

@nanosoldier runbenchmarks(ALL, isdaily = true)

@nanosoldier
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your benchmark job has completed - possible performance regressions were detected. A full report can be found here. cc @ararslan

Please sign in to comment.