Convert markup generation to a function (#43236)

Using a function to generate markup ensures that its temporary variables (e.g. `str`) are not visible any more later on, avoiding compiler warnings.

Co-authored-by: woclass <[email protected]>

doc/make.jl

@@ -46,18 +46,20 @@ end
 const render_pdf = "pdf" in ARGS
 
 # Generate a suitable markdown file from NEWS.md and put it in src
-str = read(joinpath(@__DIR__, "..", "NEWS.md"), String)
-splitted = split(str, "<!--- generated by NEWS-update.jl: -->")
-@assert length(splitted) == 2
-replaced_links = replace(splitted[1], r"\[\#([0-9]*?)\]" => s"[#\g<1>](https://github.com/JuliaLang/julia/issues/\g<1>)")
-write(
-    joinpath(@__DIR__, "src", "NEWS.md"),
-    """
-    ```@meta
-    EditURL = "https://github.com/JuliaLang/julia/blob/master/NEWS.md"
-    ```
-
-    """ * replaced_links)
+function generate_markdown(basename)
+    str = read(joinpath(@__DIR__, "..", "$basename.md"), String)
+    splitted = split(str, "<!--- generated by $basename-update.jl: -->")
+    @assert length(splitted) == 2
+    replaced_links = replace(splitted[1], r"\[\#([0-9]*?)\]" => s"[#\g<1>](https://github.com/JuliaLang/julia/issues/\g<1>)")
+    write(
+        joinpath(@__DIR__, "src", "$basename.md"),
+        """
+        ```@meta
+        EditURL = "https://github.com/JuliaLang/julia/blob/master/$basename.md"
+        ```
+        """ * replaced_links)
+end
+generate_markdown("NEWS")
 
 Manual = [
     "manual/getting-started.md",