Skip to content

Commit

Permalink
Revert "Clarify that modifyproperty! does not call convert (#45178)…
Browse files Browse the repository at this point in the history 
…" (#45209)

This reverts commit 350376b.
  • Loading branch information
@tkf
tkf authored May 7, 2022
1 parent 58ab4c7 commit 6e06132
Showing 1 changed file with 0 additions and 5 deletions.
5 changes: 0 additions & 5 deletions base/docs/basedocs.jl
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2758,11 +2758,6 @@ The syntax `@atomic max(a().b, c)` returns `modifyproperty!(a(), :b,
max, c, :sequentially_consistent))`, where the first argument must be a
`getfield` expression and is modified atomically.
Unlike [`setproperty!`](@ref Base.setproperty!), the default implementation of
`modifyproperty!` does not call `convert` automatically. Thus, `op` must return a value
that can be stored in the field `f` directly when invoking the default `modifyproperty!`
implementation.
See also [`modifyfield!`](@ref Core.modifyfield!)
and [`setproperty!`](@ref Base.setproperty!).
"""
Expand Down

2 comments on commit 6e06132

@nanosoldier
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Executing the daily package evaluation, I will reply here when finished:

@nanosoldier runtests(ALL, isdaily = true)

@nanosoldier
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your package evaluation job has completed - possible new issues were detected. A full report can be found here.

Please sign in to comment.