Skip to content

Commit

Permalink
Remove unused globalvars argument to jl_gen_llvm_gv_array
Browse files Browse the repository at this point in the history 
hopefully unbreaks master on llvm 3.3
  • Loading branch information
@tkelman
tkelman committed Jul 8, 2015
1 parent 378ab7c commit 918ee65
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/codegen.cpp
View file
Original file line number Diff line number Diff line change
Expand Up @@ -419,7 +419,7 @@ void jl_dump_bitcode(char *fname)
WriteBitcodeToFile(bitcode, OS);
#else
Module *bitcode = CloneModule(jl_Module);
jl_gen_llvm_gv_array(bitcode, globalvars);
jl_gen_llvm_gv_array(bitcode);
WriteBitcodeToFile(bitcode, OS);
#endif
}
Expand Down

1 comment on commit 918ee65

@tkelman
Copy link
Contributor Author

@tkelman tkelman commented on 918ee65 Jul 8, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whoops, if I had any coffee yet I would've rearranged the ifdef to avoid copying the two lines that are the same now - there's still a 32 bit test failure in linalg/pinv though https://travis-ci.org/JuliaLang/julia/jobs/70041689

exception on 3: ERROR: LoadError: mismatch of non-finite elements: 
  a = Inf
  0.0 = 0.0
 in test_approx_eq at test.jl:132
 in test_approx_eq at test.jl:150
 in anonymous at no file:298
 in include at ./boot.jl:254
 in runtests at /tmp/julia/share/julia/test/testdefs.jl:197
 in anonymous at multi.jl:837
 in run_work_thunk at multi.jl:590
 in anonymous at task.jl:837
while loading /tmp/julia/share/julia/test/linalg/pinv.jl, in expression starting on line 294
    From worker 2:       * linalg1              in 104.76 seconds
    From worker 5:       * linalg/cholesky      in  35.35 seconds
    From worker 4:       * linalg/triangular    in 110.26 seconds
ERROR: LoadError: LoadError: mismatch of non-finite elements: 
  a = Inf
  0.0 = 0.0
 in anonymous at task.jl:1403
while loading /tmp/julia/share/julia/test/linalg/pinv.jl, in expression starting on line 294
while loading /tmp/julia/share/julia/test/runtests.jl, in expression starting on line 5
    From worker 3:       * linalg/pinv

Please sign in to comment.