-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Forward all frontend depwarns to the logging system
Forward all frontend depwarn messages through to the julia logging system for consistency of formatting and dispatch. Deciding whether a depwarn should appear as an thrown error is also now handled outside flisp to keep this decision in one place where possible. Detail: * Ensure that deprecation-message forwards to the logging system. Also include file and line number metadata * Remove jl_parse_depwarn(), flisp *depwarn* and related scheme code as this can be handled on the julia side. * Rename syntax_deprecation_warnings(false) to without_syntax_deprecations, as this was only ever used to turn syntax deprecations off. * Ensure that all lowering depwarns with existing line number information get this passed through as accessible metadata rather than as a string. * Use distinct functions for depwarns coming from the parser vs lowering, as these get line number information in a different way. TODO: * Figure out a decent `id` for the syntax and lowering depwarn messages * Make without_syntax_deprecations filter only depwarn messages, rather than everything!
- Loading branch information
Showing
10 changed files
with
165 additions
and
141 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.