Skip to content

Commit

Permalink
Change the error messages in relpath function. (#47450)
Browse files Browse the repository at this point in the history
  • Loading branch information
@the-lazy-learner
the-lazy-learner authored Nov 8, 2022
1 parent 5a323a6 commit cf9cac2
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions base/path.jl
View file
Original file line number Diff line number Diff line change
Expand Up @@ -552,8 +552,8 @@ On Windows, case sensitivity is applied to every part of the path except drive l
`path` and `startpath` refer to different drives, the absolute path of `path` is returned.
"""
function relpath(path::String, startpath::String = ".")
isempty(path) && throw(ArgumentError("`path` must be specified"))
isempty(startpath) && throw(ArgumentError("`startpath` must be specified"))
isempty(path) && throw(ArgumentError("`path` must be non-empty"))
isempty(startpath) && throw(ArgumentError("`startpath` must be non-empty"))
curdir = "."
pardir = ".."
path == startpath && return curdir
Expand Down

13 comments on commit cf9cac2

@maleadt
Copy link
Member

@maleadt maleadt commented on cf9cac2 Nov 9, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing some PkgEval/Nanosoldier changes:

@nanosoldier runtests(["GPUifyLoops", "Example"])

@nanosoldier
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your package evaluation job has completed - possible issues were detected. A full report can be found here.

@maleadt
Copy link
Member

@maleadt maleadt commented on cf9cac2 Nov 9, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nanosoldier runtests(["GPUifyLoops", "Example"], vs = ":master")

@nanosoldier
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your package evaluation job has completed - no new issues were detected. A full report can be found here.

@maleadt
Copy link
Member

@maleadt maleadt commented on cf9cac2 Nov 9, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nanosoldier runtests(["GPUifyLoops", "Example"], vs = ":master")

@nanosoldier
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your package evaluation job has completed - possible new issues were detected. A full report can be found here.

@maleadt
Copy link
Member

@maleadt maleadt commented on cf9cac2 Nov 9, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nanosoldier runtests(["GPUifyLoops", "Example", "Run"], vs = ":master")

@maleadt
Copy link
Member

@maleadt maleadt commented on cf9cac2 Nov 9, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nanosoldier runtests(["GPUifyLoops", "Example", "Run"], vs = ":master")

@maleadt
Copy link
Member

@maleadt maleadt commented on cf9cac2 Nov 9, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nanosoldier runtests(["GPUifyLoops", "Example", "Run"], vs = ":master")

@nanosoldier
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your package evaluation job has completed - possible new issues were detected. A full report can be found here.

@maleadt
Copy link
Member

@maleadt maleadt commented on cf9cac2 Nov 9, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nanosoldier runtests(["GPUifyLoops", "Example", "Run"], vs = ":master")

@maleadt
Copy link
Member

@maleadt maleadt commented on cf9cac2 Nov 9, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nanosoldier runtests(["GPUifyLoops", "Example", "Run"], vs = ":master")

@nanosoldier
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your package evaluation job has completed - possible new issues were detected. A full report can be found here.

Please sign in to comment.