enhance Timer outer constructor taking callback to accept any valid a…

…rgs/kwargs
JuliaLang · Jun 1, 2023 · e2513d7 · e2513d7
1 parent f61bbfb
commit e2513d7
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/base/asyncevent.jl b/base/asyncevent.jl
@@ -272,8 +272,8 @@ julia> begin
 3
 ```
 """
-function Timer(cb::Function, timeout::Real; interval::Real=0.0)
-    timer = Timer(timeout, interval=interval)
+function Timer(cb::Function, timeout; kwargs...)
+    timer = Timer(timeout; kwargs...)
     t = @task begin
         unpreserve_handle(timer)
         while _trywait(timer)

diff --git a/stdlib/Dates/test/types.jl b/stdlib/Dates/test/types.jl
@@ -273,6 +273,11 @@ end
 
 end
 
+@testset "timer" begin
+    @test hasmethod(Timer, (Period,))
+    @test hasmethod(Timer, (Function, Period))
+end
+
 @testset "timedwait" begin
     @test timedwait(() -> false, Second(0); pollint=Millisecond(1)) === :timed_out
 end