Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libgit2 fails with MacOS 10.7 #20651

Closed
stevengj opened this issue Feb 17, 2017 · 6 comments
Closed

libgit2 fails with MacOS 10.7 #20651

stevengj opened this issue Feb 17, 2017 · 6 comments
Labels
libgit2 The libgit2 library or the LibGit2 stdlib module system:mac Affects only macOS

Comments

@stevengj
Copy link
Member

As reported in JuliaLang/IJulia.jl#515 by @dpsanders, the libgit2 library on MacOS is expecting a symbol _SSLCreateContext, but this symbol was apparently introduced in MacOS 10.8 (see libgit2/libgit2#3386). However, our download page advertises the binary as working in MacOS "10.7+".

Apparently it can be worked around by building libgit2 differently (libgit2/libgit2#3389).

@stevengj stevengj added libgit2 The libgit2 library or the LibGit2 stdlib module system:mac Affects only macOS labels Feb 17, 2017
@tkelman
Copy link
Contributor

tkelman commented Feb 17, 2017

Unless it's possible to dynamically detect and switch SSL library at runtime, I think the solution to this will be "drop 10.7 support" in naming, links, and documentation

@ViralBShah
Copy link
Member

ViralBShah commented Feb 17, 2017

I have been thinking about bumping the min version to 10.8 for a while now. Perhaps this is a good time. Of course, this wouldn't help the student who is experiencing the failure, but perhaps they can use JuliaBox.

@stevengj
Copy link
Member Author

stevengj commented Feb 17, 2017

The only other solution would be to build libgit2 to always use OpenSSL rather than the built-in TLS functions on MacOS. But considering that 10.8 is five years old at this point, dropping 10.7 support is not unreasonable.

@tkelman
Copy link
Contributor

tkelman commented Feb 17, 2017

using openssl is not desirable from a licensing standpoint, we've moved away from it on linux

@tkelman
Copy link
Contributor

tkelman commented Feb 17, 2017

we require 10.8 for source builds since #18910 unless you set extra non-default build flags - we've been setting MACOSX_VERSION_MIN to 10.7 on the buildbots, apparently optimistically, to avoid changing the names and links everywhere.

@staticfloat
Copy link
Member

I'm closing this as JuliaLang/www_old.julialang.org#562 was merged, so the official solution to this is "use 10.8".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
libgit2 The libgit2 library or the LibGit2 stdlib module system:mac Affects only macOS
Projects
None yet
Development

No branches or pull requests

4 participants