Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

watch_folder timeout failure on Windows #33311

Closed
stevengj opened this issue Sep 18, 2019 · 2 comments · Fixed by #33316
Closed

watch_folder timeout failure on Windows #33311

stevengj opened this issue Sep 18, 2019 · 2 comments · Fixed by #33316
Labels
ci Continuous integration io Involving the I/O subsystem: libuv, read, write, etc. system:windows Affects only Windows test This change adds or pertains to unit tests

Comments

@stevengj
Copy link
Member

See https://build.julialang.org/#/builders/65/builds/4473 (from #33291):

Error in testset FileWatching:
Test Failed at C:\cygwin\home\Administrator\buildbot\worker-tabularasa\tester_win32\build\share\julia\stdlib\v1.4\FileWatching\test\runtests.jl:388
  Expression: #= C:\cygwin\home\Administrator\buildbot\worker-tabularasa\tester_win32\build\share\julia\stdlib\v1.4\FileWatching\test\runtests.jl:388 =# @elapsed(c = watch_folder(dir, timeout)) < 0.5
   Evaluated: 0.86873192 < 0.5

from this test.

This hard-coded timeout was already increased once by @staticfloat in #27707, maybe it has to be increased again? Or is there a deeper problem?

@stevengj stevengj added system:windows Affects only Windows test This change adds or pertains to unit tests io Involving the I/O subsystem: libuv, read, write, etc. ci Continuous integration labels Sep 18, 2019
@JeffBezanson
Copy link
Sponsor Member

I've seen the value get as high as 10 seconds. Maybe all we can do for now is bump it up a little more.

@staticfloat
Copy link
Sponsor Member

The real problem is the absolutely ABYSMAL disk performance we get on windows on openstack. To give an idea, the Pkg tests running on this machine takes over 12 hours, instead of the 10 minutes that it takes on my laptop. It's a real problem, and the only reason our CI infrastructure works at all on that platform is because the entire build tree can fit into the filesystem cache.

vtjnash added a commit that referenced this issue Sep 18, 2019
This has been pretty flaky on CI systems, and isn't really required of the tests.

fix #33311
JeffBezanson pushed a commit that referenced this issue Sep 19, 2019
This has been pretty flaky on CI systems, and isn't really required of the tests.

fix #33311
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Continuous integration io Involving the I/O subsystem: libuv, read, write, etc. system:windows Affects only Windows test This change adds or pertains to unit tests
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants