Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crash when comparing a type to a kind #55768

Closed
vtjnash opened this issue Sep 13, 2024 · 0 comments · Fixed by #55770
Closed

crash when comparing a type to a kind #55768

vtjnash opened this issue Sep 13, 2024 · 0 comments · Fixed by #55770
Labels
bug Indicates an unexpected problem or unintended behavior compiler:codegen Generation of LLVM IR and native code regression 1.12 Regression in the 1.12 release

Comments

@vtjnash
Copy link
Sponsor Member

vtjnash commented Sep 13, 2024 

julia> f(z::UnionAll) = z === Vector
f (generic function with 1 method)

julia> f(Vector)
Assertion failed: (jl_is_datatype(arg1.typ) && arg1.typ == arg2.typ && !isboxed), function emit_bits_compare, file codegen.cpp, line 3474.

Exposed and/or introduced by #55508, depending on how you look at this.
@vtjnash vtjnash added bug Indicates an unexpected problem or unintended behavior compiler:codegen Generation of LLVM IR and native code regression 1.12 Regression in the 1.12 release labels Sep 13, 2024
vtjnash added a commit that referenced this issue Sep 13, 2024
@vtjnash
codegen: fix bits compare for UnionAll
f68c665 
Fixes #55768 in two parts: one is making the type computation in
emit_bits_compare agree with the parent function and two is not using
the optimized egal code for UnionAll kinds, which is different from how
the egal code itself works for kinds.
@vtjnash vtjnash mentioned this issue Sep 13, 2024
Merged
vtjnash added a commit that referenced this issue Sep 17, 2024
@vtjnash
codegen: fix bits compare for UnionAll (#55770)
0073917 
Fixes #55768 in two parts: one is making the type computation in
emit_bits_compare agree with the parent function and two is not using
the optimized egal code for UnionAll kinds, which is different from how
the egal code itself works for kinds.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Indicates an unexpected problem or unintended behavior compiler:codegen Generation of LLVM IR and native code regression 1.12 Regression in the 1.12 release
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

codegen: fix bits compare for UnionAll JuliaLang/julia
1 participant
@vtjnash