Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Permit declarations of the form f(x::Vararg{Any}) #10934

Merged
merged 1 commit into from
Apr 22, 2015
Merged

Conversation

timholy
Copy link
Sponsor Member

@timholy timholy commented Apr 21, 2015

There are a couple of things here that prepare for #10911 (e.g., checking for Varargs with two parameters), but nothing that should hurt anything.

Fixes #10925

Fixes up the expanded ast so that jl_is_rest_arg, as called from
emit_function (step 2), works properly and avoids a later segfault.
JeffBezanson added a commit that referenced this pull request Apr 22, 2015
Permit declarations of the form `f(x::Vararg{Any})`
@JeffBezanson JeffBezanson merged commit 4e986a9 into master Apr 22, 2015
@tkelman tkelman deleted the teh/varargdecl branch April 22, 2015 09:20
@timholy
Copy link
Sponsor Member Author

timholy commented Apr 22, 2015

This is potentially back-portable to 0.3, though no one running 0.3 seems to have run into this yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Segfault with the Vararg datatype
2 participants