Print filename and line number for deprecation warnings #11311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
lgtm |
|
Hmm, somehow the backtrace printed is also longer now. |
Ahh, everything is fine... This happens because my system installation has debug symbol striped (into a debug package) while the version I am testing is not striped... I bet it treat those functions as |
|
So with a striped WARNING: int32(x) is deprecated, use Int32(x) instead.
in int32 at ./deprecated.jl:33
in include_from_node1 at ./loading.jl:134
while loading /home/yuyichao/tmp/test_deprecated.jl, in expression starting on line 3
WARNING: int64(x) is deprecated, use Int64(x) instead.
in int64 at ./deprecated.jl:33
in f at /home/yuyichao/tmp/test_deprecated.jl:6
in include_from_node1 at ./loading.jl:134
while loading /home/yuyichao/tmp/test_deprecated.jl, in expression starting on line 9
ERROR: LoadError:
in error at ./error.jl:22
in include_from_node1 at ./loading.jl:134
while loading /home/yuyichao/tmp/test_deprecated.jl, in expression starting on line 11 |
|
+1 |
timholy
added a commit
that referenced
this pull request
May 17, 2015
Print filename and line number for deprecation warnings
|
This will be a very nice improvement! |
|
this is great, thanks! |
|
We should probably add a test for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added one c global variable so #10421 needs to be updated accordingly.
@vtjnash
Fix #11050