Revert "Remove unnecessary entries in jl_gcinfo_t. Update invalid ins… #11621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tructions in finalize_gc_frame", which seems to cause windows CI hanging. This reverts commit 44af242.
|
Thank you, this fixes it for me locally. Good intuition for what the problem was. |
tkelman
added a commit
that referenced
this pull request
Jun 9, 2015
Revert "Remove unnecessary entries in jl_gcinfo_t. Update invalid ins…
yuyichao
referenced
this pull request
Jun 22, 2015
this allows the lazy emission & addition of static gc roots plus, this eliminates the need to delete the gc frame (since llvm can trivially do so) and makes emit_gcpop implicit at all ret instructions, rather than explicit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…tructions in finalize_gc_frame", which seems to cause windows CI hanging.
This reverts commit 44af242.
@tkelman
(Testing locally now and let's see what does the CI think...)