Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make checkbounds more consistent & easier to extend #11895

Merged
merged 1 commit into from
Aug 26, 2015
Merged

Commits on Aug 23, 2015

  1. Make checkbounds more consistent & easier to extend

    * Remove index types from `checkbounds(A::AbstractArray, I...)` to make it easier for custom arrays to extend `checkbounds` without ambiguities.
    * Rename the internal `_checkbounds(sz::Integer, I)` to `checkbounds(::Type{Bool}, sz::Integer, I)` in order to provide a nicer name for custom array types to extend and override if they want to provide an optimized bounds check for the dimension that they are indexing into (which simply returns true or false without throwing errors).
    mbauman committed Aug 23, 2015
    2 Configuration menu
    Copy the full SHA
    161d4fd View commit details
    Browse the repository at this point in the history