Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tune GC heuristics for big remsets. #12632

Merged
merged 1 commit into from
Aug 28, 2015
Merged

Tune GC heuristics for big remsets. #12632

merged 1 commit into from
Aug 28, 2015

Conversation

jiahao
Copy link
Member

@jiahao jiahao commented Aug 15, 2015

Take the number of pointers transgressing the generational frontier
into account when deciding wether to do a young or an old gen
collection. Helps #10428. Didn't run the bench suite yet.

@kshyatt kshyatt added the GC Garbage collector label Aug 15, 2015
@yuyichao
Copy link
Contributor

Most of the conflicts seems to be cause by my reorganization for gc debugging. Will push a rebased version later.

Take the number of pointers transgressing the generational frontier
into account when deciding wether to do a young or an old gen
collection. Helps #10428. Didn't run the bench suite yet.
@yuyichao
Copy link
Contributor

The original branch is backed up at the yyc/gctune.bak branch with the commit SHA 238ed08.

Rebased version force pushed to the ob/gctune branch.

@yuyichao
Copy link
Contributor

@carnaval

@@ -1708,10 +1715,12 @@ static int push_root(jl_value_t *v, int d, int bits)
}
}
else if (vt == (jl_value_t*)jl_module_type) {
// should increase nptr here
Copy link
Sponsor Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this an action item, or a comment on what it does, or neither?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does look like a dangerous comment.

@JeffBezanson
Copy link
Sponsor Member

Cool! How much does it help readdlm?

@carnaval
Copy link
Contributor

so this is the change that has been rotting away on one of my branches for a long time. Last time I tried it solved the runaway heuristic thing, and brought down the time from 95% gc to around 20% in my recollection.

I probably wont have time to test it again until next week.

@jakebolewski
Copy link
Member

Bump. It would be nice to run the performance tests and get this in for 0.4.

@simonster
Copy link
Member

i take full responsability

simonster added a commit that referenced this pull request Aug 28, 2015
Tune GC heuristics for big remsets.
@simonster simonster merged commit 366e2d5 into master Aug 28, 2015
@simonster
Copy link
Member

@carnaval is drunk

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GC Garbage collector
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants