change for i in 1:length(a) to i in eachindex(a) (continuing #10858) #12788
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevengj
force-pushed
the
eachindex_everywhere
branch
from
5df7daa
to
bc557e2
Compare
| @@ -10,6 +10,7 @@ eltype{T<:Number}(::Type{T}) = T | |||
| ndims(x::Number) = 0 | |||
| ndims{T<:Number}(::Type{T}) = 0 | |||
| length(x::Number) = 1 | |||
| eachindex(x::Number) = 1 | |||
There was a problem hiding this comment.
:( cant wait for that to go away
|
Closing as this seems more trouble than it is worth. |
|
Obviously, it will be good to have something like this return in 0.5. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuing the changes made in #10858 and #8432, this changes
for i = 1:length(a)tofor i in eachindex(a)throughout Base, and adds missingeachindexmethods forNumberandTupletypes (which are required for generic code).There should be no performance penalty to this, since in most cases
eachindex(a)inlines to1:length(a)anyway. But since usingeachindex(a)in loops is now the preferred style, it seemed best to do it consistently in Base, both to establish the habit and to catch any problems.