Remove guarantee of at-test_throw return type. #13097
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In preparation for new test system. Partial revert of #11984.
IainNZ
added
docs
|
@yuyichao you okay with this? |
|
Yes. |
tkelman
added a commit
that referenced
this pull request
Sep 13, 2015
Remove guarantee of at-test_throw return type.
|
Dunno if un-documenting something is the greatest way of preventing people from using it in anticipation of breaking it soon, but it's better than nothing. |
|
Technically it isn't breaking since there hasn't been a release using the feature ;) |
|
Unless we intentionally break it soon there's about to be. |
|
I have no solution to that part |
|
backported in #13107 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation for new test system. Partial revert of #11984. Follows from discussion in #13090.