Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop extraneous line and add tests for matmul #13098

Merged
merged 1 commit into from
Sep 13, 2015
Merged

Drop extraneous line and add tests for matmul #13098

merged 1 commit into from
Sep 13, 2015

Conversation

kshyatt
Copy link
Contributor

@kshyatt kshyatt commented Sep 12, 2015

copytri was checking the uplo argument twice.

Added more tests for a bunch of error throwing/misc methods.

@kshyatt kshyatt added test This change adds or pertains to unit tests linear algebra Linear algebra labels Sep 12, 2015
jakebolewski added a commit that referenced this pull request Sep 13, 2015
@jakebolewski
Merge pull request #13098 from JuliaLang/ksh/matmul
4e8f24e 
Drop extraneous line and add tests for matmul
@jakebolewski jakebolewski merged commit 4e8f24e into master Sep 13, 2015
@kshyatt kshyatt deleted the ksh/matmul branch September 13, 2015 16:43
@tkelman
Copy link
Contributor

tkelman commented Sep 13, 2015

mostly a test addition, may as well backport

kshyatt added a commit that referenced this pull request Sep 13, 2015
@kshyatt @tkelman
Drop extraneous line and add tests for matmul
20fa353 
(cherry picked from commit 3818013)
ref #13098
@tkelman
Copy link
Contributor

tkelman commented Sep 16, 2015

backported in #13107

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
linear algebra Linear algebra test This change adds or pertains to unit tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kshyatt @tkelman @jakebolewski