DLLEXPORT clean up #14219
Merged
DLLEXPORT clean up #14219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuyichao
force-pushed
the
yyc/export-cleanup
branch
from
d74c239
to
81f0b50
Compare
|
should we take this opportunity to rename the define |
|
Sure, I can do that. |
|
Done |
|
I'll merge this later today if there's no other issues. |
Also remove unexported function from `julia.h` and remove prototypes of functions that does not exist anymore.
yuyichao
force-pushed
the
yyc/export-cleanup
branch
from
6269e68
to
284656b
Compare
|
Rebase to resolve merge conflict with 240374c . Will merge when CI is gree. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on #14190 I need to know if a function is
DLLEXPORT'ed when looking at the function definition (functions that will not be called from arbitrary places can have a relaxed requirement on the GC state convention). This PR sync all theDLLEXPORTattribute also to the function definition so it is easier to reason about where can the function be called without jumping between files.This also removes non
DLLEXPORT'ed functions and the declarations of removed functions fromjulia.h.