Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-0.4] backport ARM ABI #15638

Merged
merged 4 commits into from
Apr 1, 2016
Merged

[release-0.4] backport ARM ABI #15638

merged 4 commits into from
Apr 1, 2016

Conversation

tkelman
Copy link
Contributor

@tkelman tkelman commented Mar 27, 2016

Backporting #14194 again, but this time in a way that should build correctly on release-0.4.

@tkelman
Copy link
Contributor Author

tkelman commented Mar 27, 2016

A colleague hit a segfault where the root cause was calling float("0"). ccall ABI fixes it.

runbenchmarks("all", vs = "JuliaLang/julia:v0.4.3")

@jrevels
Copy link
Member

jrevels commented Mar 27, 2016

The format allowed for vs is "user/repo:branch" or "user/repo@sha". It'd be nice if it accepted tags, though...

Also, I think you were looking for the keyword ALL, which is a placeholder that matches all benchmarks:

runbenchmarks(ALL, vs = "JuliaLang/julia@a2f713dea5ac6320d8dcf2835ac4a37ea751af05")

@nanosoldier
Copy link
Collaborator

Your benchmark job has completed - possible performance regressions were detected. A full report can be found here. cc @jrevels

@tkelman
Copy link
Contributor Author

tkelman commented Mar 31, 2016

are those regressions serious enough to worry about? what's the best way to replicate locally? this makes the arm build work much much better on release-0.4

@tkelman tkelman added the system:arm ARMv7 and AArch64 label Mar 31, 2016
@jrevels
Copy link
Member

jrevels commented Mar 31, 2016

The timing regressions are all from benchmarks that have proven very noisy in the past. The ~83x allocation count regression on the in-place insertion sort benchmark is weird, though, and worth checking out. I could tell you how to do it using BaseBenchmarks.jl, but those instructions will be obsolete soon, so it'll probably be easier just to check it manually:

list = rand(MersenneTwister(1), 50000)
@time sort!(list, alg = InsertionSort)

I'm currently building this branch locally to see if I can reproduce the regression using the newer benchmark tools, I'll report back if I find anything relevant.

Edit: I can't reproduce the regression locally using the new tools, must've been a fluke.

@tkelman tkelman merged commit 198644a into release-0.4 Apr 1, 2016
@tkelman tkelman deleted the tk/armabi0.4 branch April 1, 2016 03:37
@tkelman
Copy link
Contributor Author

tkelman commented Apr 1, 2016

Thanks @jrevels!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
system:arm ARMv7 and AArch64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants