-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-0.4] backport ARM ABI #15638
Conversation
A colleague hit a segfault where the root cause was calling
|
The format allowed for Also, I think you were looking for the keyword
|
Your benchmark job has completed - possible performance regressions were detected. A full report can be found here. cc @jrevels |
are those regressions serious enough to worry about? what's the best way to replicate locally? this makes the arm build work much much better on release-0.4 |
The timing regressions are all from benchmarks that have proven very noisy in the past. The ~83x allocation count regression on the in-place insertion sort benchmark is weird, though, and worth checking out. I could tell you how to do it using BaseBenchmarks.jl, but those instructions will be obsolete soon, so it'll probably be easier just to check it manually: list = rand(MersenneTwister(1), 50000)
@time sort!(list, alg = InsertionSort) I'm currently building this branch locally to see if I can reproduce the regression using the newer benchmark tools, I'll report back if I find anything relevant. Edit: I can't reproduce the regression locally using the new tools, must've been a fluke. |
Thanks @jrevels! |
Backporting #14194 again, but this time in a way that should build correctly on release-0.4.