Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Look for fesetround in libm rather than the executable #16291

Closed
wants to merge 1 commit into from

Conversation

Keno
Copy link
Member

@Keno Keno commented May 10, 2016

We usually get lucky because GCC's runtime library includes this functions.
However, their proper place is in the math library and Clang's runtime
library does not include these functions on windows, so without this change
the function is not found.

Also bump openlibm to include the latest changes that make openlibm
work with clang on windows.

@@ -1,2 +1,2 @@
OPENLIBM_BRANCH=v0.4.1
OPENLIBM_SHA1=3ee2a6e6a9fc68cbf2ab00f830b9059215e40b06
OPENLIBM_SHA1=5fd9dcbbdf8565281c1b15f7cdc9d8594e70426a
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this a tag? delete the old checksums

@tkelman
Copy link
Contributor

tkelman commented May 10, 2016

we statically link libm into the executable on windows for this kind of thing

@StefanKarpinski
Copy link
Sponsor Member

we statically link libm into the executable on windows for this kind of thing

Still, this is more correct and does no harm, so we should do it, no?

@tkelman
Copy link
Contributor

tkelman commented May 10, 2016

Separately from a version change maybe. We should only be using a tagged version of openlibm, and Viral had a PR not that long ago that also upgraded openspecfun.

Isn't some of the floating point environment controlled on a per shared library basis? Rearranging bootstrap to move the os dependent parts so much earlier is also a little unfortunate.

@Keno
Copy link
Member Author

Keno commented May 14, 2016

@ViralBShah Can we tag a new openlibm version? It would be nice if windows build out of the box.

We usually get lucky because GCC's runtime library includes this functions.
However, their proper place is in the math library and Clang's runtime
library does not include these functions on windows, so without this change
the function is not found.
@vtjnash
Copy link
Sponsor Member

vtjnash commented Jun 23, 2016

We usually get lucky because GCC's runtime library includes this functions.
However, their proper place is in the math library and Clang's runtime
library does not include these functions on windows, so without this change
the function is not found.

this isn't entirely true. on windows, iirc, it is usually provided as a statically linked file by the CRT. But my recollection was that we were actually providing this as an export from libjulia.dll and ./julia, due to our static linking to libopenlibm (which declares them DLLEXPORT).

@vtjnash
Copy link
Sponsor Member

vtjnash commented Oct 26, 2020

Executed in 7e8f2c0 (#36588)

@vtjnash vtjnash closed this Oct 26, 2020
@DilumAluthge DilumAluthge deleted the kf/clangwinround branch March 25, 2021 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants