deprecate WString and wstring #16975
Conversation
StefanKarpinski
force-pushed
the
sk/rm-wstring
branch
from
72f7332
to
723a4ee
Compare
| if sizeof(Cwchar_t) == 2 | ||
| @deprecate_binding WString UTF16String | ||
| @deprecate_binding wstring utf16 | ||
| utf16(s::Cwstring) = utf16(convert(Ptr{Cwchar_t}, s)) |
There was a problem hiding this comment.
tab again
more consequentially, these deprecations are platform-dependent which defeats the purpose of them having a separate name
There was a problem hiding this comment.
I'm not sure how to fix that since this was an alias anyway ¯\_(ツ)_/¯
There was a problem hiding this comment.
we should probably recommend something that involves if is_windows() a; else b; end
(or equivalent with sizeof(Cwchar_t) if that's not going to be deprecated)
There was a problem hiding this comment.
Right, but the binding deprecation isn't going to be possible to handle that way anyhow.
There was a problem hiding this comment.
I'm going to leave this since the next step is to delete UTF16 and UTF32 anyway.
There was a problem hiding this comment.
Didn't see this since it was collapsed, but what's the replacement going to be here? Wherever that moves to, this deprecation should direct to something correct.
StefanKarpinski
force-pushed
the
sk/rm-wstring
branch
3 times, most recently
from
2c7372f
to
cb23547
Compare
|
appveyor failures are real here, just so your merge finger doesn't get too itchy |
StefanKarpinski
force-pushed
the
sk/rm-wstring
branch
from
cb23547
to
89cdf63
Compare
StefanKarpinski
force-pushed
the
sk/rm-wstring
branch
from
89cdf63
to
91e4340
Compare
|
YESSS! I finally got this bugger to pass on Windows. |
|
Failure is a timeout. The other Windows run passed. Tempted to merge... |
|
The deprecation here is pretty flawed and is going to lead people to write code that doesn't behave cross platform the way they thought it might from using these aliases. |
|
Compat also needs fixing for this. |
|
Once we delete UTF(16|32)String, these deprecations have to be deleted. I'm not sure what they can be replaced with unless we keep the entirety of those types around in base/deprecated.jl, which seems insane. |
|
It should redirect to something that does the right thing, whether or not that's in base. If that doesn't exist yet, then we're not ready to remove the types. |
No description provided.