Append newline to the end of dump methods #17202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1158,6 +1168,7 @@ function dumptype(io::IO, x::ANY, n::Int, indent) | |||
| end | |||
| end | |||
| end | |||
| isempty(indent) && println(io) | |||
| end | |||
There was a problem hiding this comment.
Maybe all the dump methods should explicitly return nothing?
There was a problem hiding this comment.
Yes; otherwise they return false which doesn't really make sense.
|
LGTM. Anyone else have thoughts? |
|
Would be nice to get this merged. |
| @@ -500,3 +500,9 @@ let s = IOBuffer(Array{UInt8}(0), true, true) | |||
| Base.showarray(s, [1,2,3], false, header = false) | |||
| @test String(resize!(s.data, s.size)) == " 1\n 2\n 3" | |||
| end | |||
|
|
|||
| # The `dump` function should alway have a trailing newline | |||
There was a problem hiding this comment.
Thanks. I'll take care of that in another PR
omus
added a commit
to omus/julia
that referenced
this pull request
Jul 8, 2016
mfasi
pushed a commit
to mfasi/julia
that referenced
this pull request
Sep 5, 2016
* Append newline to the end of dump methods * Made dump methods return nothing
mfasi
pushed a commit
to mfasi/julia
that referenced
this pull request
Sep 5, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The doctest system doesn't deal very well with examples that don't have a trailing newline. Originally mentioned in #17106 and in the julia-dev forums
This is my first time making modifications to the
dumpmethods. Let me know if there's something I didn't consider.