Fix type instability in setindex! for SparseMatrixCSCs #17343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This could also be solved by not using the same name for both sides of lines that look like |
|
Might be slightly better this way, though: many variants of the short wrapper can be compiled, all of which call a single variant (per array leaftype) of the "complicated" function. Less codegen this way. |
|
Good point. Sold. |
|
Thanks for the review and merge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type instability occurs when calling
setindex!on aSparseMatrixCSC{Tv,Ti}with indices-value triple(i,j,v)wheretypeof(i) != Ti || typeof(j) != Ti || typeof(v) != Tv. Best!