Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename AbstractIOBuffer, it's not an abstract type #17360

Closed
wants to merge 3 commits into from
Closed

Rename AbstractIOBuffer, it's not an abstract type #17360

wants to merge 3 commits into from

Commits on Jul 12, 2016

  1. adjust indentation in doc/manual/types.rst

    @tkelman
    tkelman committed Jul 12, 2016
    Configuration menu
    Copy the full SHA
    0054026 View commit details
    Browse the repository at this point in the history

  2. Remove use of 'abstract type' when discussing parametric composite types 

    this is a bit confusing and we don't have a great word for it,
but since Point wasn't declared with abstract here we probably
shouldn't use that term
    @tkelman
    tkelman committed Jul 12, 2016
    Configuration menu
    Copy the full SHA
    0e834c5 View commit details
    Browse the repository at this point in the history

  3. Rename AbstractIOBuffer to IOBufferBase 

    ref discussion at #11554 (comment)
it might be better to rename this to IOBuffer but I'm not sure how to make that work
    @tkelman
    tkelman committed Jul 12, 2016
    Configuration menu
    Copy the full SHA
    ebff12b View commit details
    Browse the repository at this point in the history