run deps checks in make binary-dist
#17637
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tkelman
force-pushed
the
tk/checkdeps
branch
2 times, most recently
from
6c9b9c8
to
8151079
Compare
tkelman
changed the title
make binary-distmake binary-dist
tkelman
changed the title
make binary-distmake binary-dist
this could use further investigation
This should have been done in #14517 before that was merged Make check targets a bit more consistent Add a TODO on the currently-disabled libuv tests, enable patchelf which seems fine now, and don't run suitesparse tests when cross-compiling
tkelman
force-pushed
the
tk/checkdeps
branch
from
d63320c
to
3b7040c
Compare
patchelf tests fail on power, skip running them there for now
tkelman
force-pushed
the
tk/checkdeps
branch
from
8555d35
to
df1bfea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bunch of these were removed from the default build in #14517, but they should have been put in binary-dist or release-candidate. They take a fair amount of time and aren't needed for every single Julia source build, but it is a good idea to check against them for binaries or releases. They have a different set of test coverage than our Julia-level bindings for them.
WIP because:
not-yet-mergednot-yet-tagged utf8proc PR to build its tests correctlymbedtls and maybelibunwind failures deserve looking into and should be fixable with hopefully not-too-complicated patches