Allow calls to kwarg functions before Base is defined. #18396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maleadt
force-pushed
the
tb/core_kwargs
branch
from
e84a9f9
to
cdf9daa
Compare
|
yes, any for testing, you could use some variant of: julia> eval(Core.Inference, quote
f(;x...) = println(;x...)
end)
f (generic function with 1 method)
julia> Core.Inference.f(a=1, b=2, c=3)
ERROR: UndefVarError: vector_any not defined
in #f#213(::Array{Any,1}, ::Function) at REPL[1]:2
in (::Core.Inference.#kw##f)(::Array{Any,1}, ::Core.Inference.#f) at <missing>:0
in eval(::Module, ::Any) at ./boot.jl:234
in eval(::Module, ::Any) at /Volumes/Lion/Users/jameson/Documents/julia/usr/lib/julia/sys.dylib:?
in eval_user_input(::Any, ::Base.REPL.REPLBackend) at REPL.jl:66
in macro expansion; at REPL.jl:97 [inlined]
in (::Base.REPL.##3#4{Base.REPL.REPLBackend})() at event.jl:68 |
This enables calls to kwarg functions before Base is defined (eg. in inference), as the frontend generates a call to vector_any.
maleadt
force-pushed
the
tb/core_kwargs
branch
from
cdf9daa
to
d75e4eb
Compare
maleadt
added a commit
that referenced
this pull request
Sep 13, 2016
Call a kwarg function in Core.Inference where vector_any was unavailable.
maleadt
added
regression
|
Thanks. Turns out this did work on 0.4, so I've added the regression label. |
| f18396(;kwargs...) = g18396(;kwargs...) | ||
| g18396(;x=1,y=2) = x+y | ||
| end) | ||
| Core.Inference.f18396() |
There was a problem hiding this comment.
probably best to also @test the return value so that it is also confirmed to do something
maleadt
force-pushed
the
tb/core_kwargs
branch
from
d75e4eb
to
8ea9a72
Compare
maleadt
added a commit
that referenced
this pull request
Sep 13, 2016
Call a kwarg function in Core.Inference where vector_any was unavailable.
Call a kwarg function in Core.Inference where vector_any was unavailable.
maleadt
force-pushed
the
tb/core_kwargs
branch
from
8ea9a72
to
fab9560
Compare
|
waiting until 0.5.1 |
tkelman
pushed a commit
that referenced
this pull request
Feb 22, 2017
This enables calls to kwarg functions before Base is defined (eg. in inference), as the frontend generates a call to vector_any. (cherry picked from commit 95c26b5) ref #18396 Add a test for #18396. Call a kwarg function in Core.Inference where vector_any was unavailable. (cherry picked from commit fab9560)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Used in #18338.
Couldn't find a way to test..