Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial setup to move modules out of Base to a stdlib #19628

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions base/exports.jl
Original file line number Diff line number Diff line change
Expand Up @@ -954,9 +954,6 @@ export
rfft,
xcorr,

# numerical integration
quadgk,

# iteration
done,
next,
Expand Down
1 change: 1 addition & 0 deletions base/initdefs.jl
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@ function init_load_path()
end
push!(LOAD_PATH, abspath(JULIA_HOME, "..", "local", "share", "julia", "site", vers))
push!(LOAD_PATH, abspath(JULIA_HOME, "..", "share", "julia", "site", vers))
push!(LOAD_PATH, abspath(JULIA_HOME, "..", "..", "stdlib"))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why don't we just use site for this? it's already on load path

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, that's probably a good idea; even though it's not totally obvious that it's the julia stdlib, it makes more sense because long-term we're planning on moving things out of this repo anyway.

#push!(LOAD_CACHE_PATH, abspath(JULIA_HOME, "..", "lib", "julia")) #TODO: add a builtin location?
end

Expand Down
9 changes: 5 additions & 4 deletions base/sysimg.jl
Original file line number Diff line number Diff line change
Expand Up @@ -329,10 +329,6 @@ importall .DFT
include("dsp.jl")
importall .DSP

# Numerical integration
include("quadgk.jl")
importall .QuadGK

# Fast math
include("fastmath.jl")
importall .FastMath
Expand Down Expand Up @@ -397,4 +393,9 @@ end # baremodule Base
using Base
importall Base.Operators

# stdlib packages
# Numerical integration
Base.include("../stdlib/QuadGK.jl")
using QuadGK

Base.isfile("userimg.jl") && Base.include("userimg.jl")
File renamed without changes.