Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include world age in thread work #19886

Merged
merged 1 commit into from
Jan 8, 2017
Merged

Include world age in thread work #19886

merged 1 commit into from
Jan 8, 2017

Conversation

yuyichao
Copy link
Contributor

@yuyichao yuyichao commented Jan 6, 2017

Similar to how we deal with current_module.

Fix #19876

@yuyichao yuyichao added the multithreading Base.Threads and related functionality label Jan 6, 2017
@yuyichao
Copy link
Contributor Author

yuyichao commented Jan 6, 2017

I triggered two threading buildbot build at https://build.julialang.org/builders/nightly_threading-x64
and https://build.julialang.org/builders/nightly_threading-x86. There are other known failures though so they might still hang in the threading tests.

tkelman
tkelman reviewed Jan 6, 2017
View reviewed changes
src/threading.h
@@ -43,6 +43,7 @@ typedef struct {
jl_svec_t *args;
jl_value_t *ret;
jl_module_t *current_module;
size_t world_age;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

may as well align it with the other fields?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK.....

@yuyichao
Copy link
Contributor Author

yuyichao commented Jan 6, 2017

The 32bit one shows the expected intermittent hang. The 64bit one seems to have built the wrong version....

Revision 770898e
Got Revision 84d9eac

@staticfloat

@staticfloat
Copy link
Sponsor Member

Huh, weird, when it tried to check it out, git said fatal: Could not parse object '770898e984e0f676a759946405983ee3b307eca1'. I've asked it to do another one, to see if it works any better this time around.

@kshyatt
Copy link
Contributor

kshyatt commented Jan 6, 2017

@staticfloat what was the outcome?

@staticfloat
Copy link
Sponsor Member

staticfloat commented Jan 6, 2017 •
edited
Loading

Oh, I see what happened. You force-pushed to this branch, so the commit 770898e disappeared and the buildbot got confused. I've started up a new build against gitsha 673e6f0 now.

EDIT:
32-bit builder
64-bit builder

@yuyichao yuyichao merged commit e55cdea into master Jan 8, 2017
@yuyichao yuyichao deleted the yyc/threads/world branch January 8, 2017 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tkelman tkelman tkelman left review comments

@vtjnash vtjnash vtjnash approved these changes

Assignees
No one assigned
Labels
multithreading Base.Threads and related functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@yuyichao @staticfloat @kshyatt @vtjnash @tkelman