Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

codegen emit constant data as llvm constants #21277

Merged
merged 2 commits into from
Apr 6, 2017
Merged

codegen emit constant data as llvm constants #21277

merged 2 commits into from
Apr 6, 2017

Conversation

vtjnash
Copy link
Sponsor Member

@vtjnash vtjnash commented Apr 4, 2017

this allows llvm to optimize constant data access
fix #21121

@JeffBezanson
Copy link
Sponsor Member

Any effect on sysimg size?

@ararslan ararslan added bugfix This change fixes an existing bug compiler:codegen Generation of LLVM IR and native code labels Apr 4, 2017
@vtjnash
Copy link
Sponsor Member Author

vtjnash commented Apr 4, 2017

@nanosoldier runbenchmarks(ALL, vs=":master")

@vtjnash
Copy link
Sponsor Member Author

vtjnash commented Apr 4, 2017

Doesn't seem to be significant

@nanosoldier
Copy link
Collaborator

Your benchmark job has completed - possible performance regressions were detected. A full report can be found here. cc @jrevels

@vtjnash vtjnash removed the bugfix This change fixes an existing bug label Apr 5, 2017
@vtjnash
Copy link
Sponsor Member Author

vtjnash commented Apr 5, 2017

@nanosoldier runbenchmarks(ALL, vs=":master")

@nanosoldier
Copy link
Collaborator

Your benchmark job has completed - possible performance regressions were detected. A full report can be found here. cc @jrevels

@ararslan
Copy link
Member

ararslan commented Apr 5, 2017

Are the SIMD regressions for a reason similar to that in #21279?

@vtjnash
Copy link
Sponsor Member Author

vtjnash commented Apr 5, 2017

AFAICT, the generate code is identical and those are just noise. But might as well ask @nanosoldier runbenchmarks("simd", vs=":master")

@nanosoldier
Copy link
Collaborator

Your benchmark job has completed - no performance regressions were detected. A full report can be found here. cc @jrevels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compiler:codegen Generation of LLVM IR and native code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Boxed tuples leaking into generated code
4 participants