Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make reshape(::BitArray,...) type stable #21670

Merged
merged 1 commit into from
May 3, 2017
Merged

Make reshape(::BitArray,...) type stable #21670

merged 1 commit into from
May 3, 2017

Commits on May 2, 2017

  1. Make reshape(::Bitarray,...) type stable 

    This works around some of the performance regressions flagged in #20993. The instability itself is not new nor is it the cause of the regression. The trouble is just that there are a few more inlined functions now, each of which needs a dynamic dispatch.

It is worth noting that 0.6 (with this patch) is significantly faster than 0.5 (with this patch). I measure an improvement of ~30%.
    @mbauman
    mbauman committed May 2, 2017
    Configuration menu
    Copy the full SHA
    a6241dc View commit details
    Browse the repository at this point in the history