Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #21848, bug in widening done by limit_type_depth #21907

Merged
merged 1 commit into from
May 17, 2017
Merged

fix #21848, bug in widening done by limit_type_depth #21907

merged 1 commit into from
May 17, 2017

Conversation

JeffBezanson
Copy link
Sponsor Member

This would widen e.g. Complex{T} where T to _ <: Complex, which is valid in some sense but yields a type that's not a supertype of the input, which is bad.

@JeffBezanson
fix #21848, bug in widening done by limit_type_depth
f46ba0a 
This would widen e.g. `Complex{T} where T` to `_ <: Complex`, which
is valid in some sense but yields a type that's not a supertype of
the input, which is bad.
@JeffBezanson
Copy link
Sponsor Member Author

Thanks to @vtjnash for the original version of this patch in #21848 (comment).

@JeffBezanson JeffBezanson mentioned this pull request May 16, 2017
Closed
@KristofferC
Copy link
Sponsor Member

@nanosoldier runbenchmarks(ALL, vs = ":master")

@JeffBezanson JeffBezanson added bugfix This change fixes an existing bug compiler:inference Type inference backport pending 0.6 labels May 16, 2017
@nanosoldier
Copy link
Collaborator

Your benchmark job has completed - possible performance regressions were detected. A full report can be found here. cc @jrevels

@JeffBezanson JeffBezanson merged commit 64a230b into master May 17, 2017
@JeffBezanson JeffBezanson deleted the jb/fix21848 branch May 17, 2017 03:29
tkelman pushed a commit that referenced this pull request May 17, 2017
@JeffBezanson @tkelman
fix #21848, bug in widening done by limit_type_depth
09d3b26 
This would widen e.g. `Complex{T} where T` to `_ <: Complex`, which
is valid in some sense but yields a type that's not a supertype of
the input, which is bad.

(cherry picked from commit f46ba0a)
ref #21907
@vtjnash vtjnash mentioned this pull request May 18, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vtjnash vtjnash vtjnash approved these changes

Assignees
No one assigned
Labels
bugfix This change fixes an existing bug compiler:inference Type inference
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@JeffBezanson @KristofferC @nanosoldier @vtjnash @tkelman