Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add NEWS.md entry for midpoints deprecation #21930

Merged
merged 1 commit into from
May 20, 2017

Conversation

Sacha0
Copy link
Member

@Sacha0 Sacha0 commented May 17, 2017

Ref. #21475. Best!

@Sacha0 Sacha0 added the needs news A NEWS entry is required for this change label May 17, 2017
@Sacha0 Sacha0 added this to the 0.6.0 milestone May 17, 2017
@ararslan ararslan merged commit f988566 into JuliaLang:master May 20, 2017
@Sacha0 Sacha0 deleted the news20058 branch May 20, 2017 19:27
@Sacha0 Sacha0 removed the needs news A NEWS entry is required for this change label May 20, 2017
@giordano
Copy link
Contributor

Am I missing something or there is no midpoint function in StatBase? I can see only a midpoints exported but defined nowhere.

@Sacha0
Copy link
Member Author

Sacha0 commented May 21, 2017

Am I missing something or there is no midpoint function in StatBase? I can see only a midpoints exported but defined nowhere.

Good catch! midpoint is a typo. Touchup inbound. Much thanks @giordano! :)

@Sacha0
Copy link
Member Author

Sacha0 commented May 21, 2017

(#22008)

@giordano
Copy link
Contributor

You welcome! But still, midpoints was removed from StatsBase with JuliaStats/StatsBase.jl#144 So I don't think it's useful to refer to a non existing function.

@Sacha0
Copy link
Member Author

Sacha0 commented May 21, 2017

Good point! I checked only that StatsBase.midpoints exists, not for deprecation. Writing out the comprehensions suggested in the deprecations (in both Base and StatsBase) in NEWS.md seems a bit overlong. What would you suggest instead? Thanks again! :)

@Sacha0
Copy link
Member Author

Sacha0 commented May 21, 2017

Or perhaps midpoints should be un-deprecated in StatsBase, the argument for midpoints's deprecation from StatsBase seemingly being midpoints's inclusion in Base? Thoughts @ararslan @andreasnoack ?

@ararslan
Copy link
Member

The midpoints deprecation suggestion is complex enough that it seems like it would be nice to have a function that does it for you. I agree that it would be good to un-deprecate it in StatsBase.

@giordano
Copy link
Contributor

Probably JuliaStats/StatsBase.jl#144 can be simply reverted, also histrange is no more in Julia's Base.

tkelman pushed a commit that referenced this pull request Jun 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants