Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add docs for isbare/isattached #22557

Merged
merged 2 commits into from
Jun 27, 2017
Merged

Add docs for isbare/isattached #22557

merged 2 commits into from
Jun 27, 2017

Conversation

kshyatt
Copy link
Contributor

@kshyatt kshyatt commented Jun 26, 2017

No description provided.

@kshyatt kshyatt added docs This change adds or pertains to documentation libgit2 The libgit2 library or the LibGit2 stdlib module labels Jun 26, 2017
@kshyatt kshyatt requested a review from ararslan June 26, 2017 18:39
@kshyatt kshyatt mentioned this pull request Jun 26, 2017
Closed
ararslan
ararslan approved these changes Jun 26, 2017
View reviewed changes
Copy link
Member

@ararslan ararslan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Imperative would be good for consistency otherwise lgtm

@kshyatt
Copy link
Contributor Author

kshyatt commented Jun 26, 2017

make check-whitespace passes locally and I fixed a few other verbs

ararslan
ararslan approved these changes Jun 26, 2017
View reviewed changes
Copy link
Member

@ararslan ararslan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Boom, double approval

Sacha0
Sacha0 reviewed Jun 26, 2017
View reviewed changes
base/libgit2/repository.jl
isattached(repo::GitRepo) -> Bool

Determine if `repo` is detached - that is, whether its HEAD points to a commit
(detached) or whether HEAD points to a branch tip (attached).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For consistency, perhaps "whether its HEAD points to ... or whether its HEAD points to ..." or simplify to "whether its HEAD points to ... or to ..."?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this would be better, yes - was not addressed

Sacha0
Sacha0 approved these changes Jun 26, 2017
View reviewed changes
Copy link
Member

@Sacha0 Sacha0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! :)

@kshyatt kshyatt merged commit 4dae4db into master Jun 27, 2017
@kshyatt kshyatt deleted the ksh/docbareattached branch June 27, 2017 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tkelman tkelman tkelman left review comments

@Sacha0 Sacha0 Sacha0 approved these changes

@ararslan ararslan ararslan approved these changes

Assignees
No one assigned
Labels
docs This change adds or pertains to documentation libgit2 The libgit2 library or the LibGit2 stdlib module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kshyatt @Sacha0 @tkelman @ararslan