switch more code to where syntax. part of #11310.
#22823
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tkelman
reviewed
Jul 15, 2017
base/deprecated.jl
Outdated
| @deprecate literal_pow{N}(a, b, ::Type{Val{N}}) literal_pow(a, b, Val(N)) false | ||
| @eval IteratorsMD @deprecate split{n}(t, V::Type{Val{n}}) split(t, Val(n)) false | ||
| @deprecate sqrtm{T,realmatrix}(A::UpperTriangular{T},::Type{Val{realmatrix}}) sqrtm(A, Val(realmatrix)) | ||
| @deprecate ntuple(f, ::Type{Val{N}}) where N ntuple(f, Val(N)) |
There was a problem hiding this comment.
where {N} or parens around the entire old expr would make this a lot clearer
There was a problem hiding this comment.
It's a deprecation.
There was a problem hiding this comment.
still going to show up in @which, and it's newly added so going to be around for a bit
ararslan
approved these changes
Jul 15, 2017
JeffBezanson
force-pushed
the
jb/fix11310
branch
from
050526f
to
47d1324
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.