Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crush the vectorized method resistance #22961

Merged
merged 3 commits into from
Aug 7, 2017
Merged

Conversation

Sacha0
Copy link
Member

@Sacha0 Sacha0 commented Jul 25, 2017

Fly the red flag and grant them no quarter.

Fixes #22959. Needs news? Best!

@Sacha0 Sacha0 added deprecation This change introduces or involves a deprecation sparse Sparse arrays broadcast Applying a function over a collection labels Jul 25, 2017
:acos, :acot, :acosd, :acotd,
:cosh, :csch, :coth, :sech,
:acsch, :asech]
@eval @unarymap_z2nz $(op) Number
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we could also deprecate this macro? (or remove if not used outside of base)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Absolutely, chances are most of the Xmap_YZ macros/functions for SparseVectors can be cleaned out with some care :). Would a separate pull request be alright?

@martinholters
Copy link
Member

https://www.youtube.com/watch?v=8CP9dg38cAI

@fredrikekre
Copy link
Member

Perhaps add a NEWS bullet and this should be good to go?

@Sacha0
Copy link
Member Author

Sacha0 commented Aug 5, 2017

Perhaps add a NEWS bullet and this should be good to go?

Thanks for the bump! Added a commit with news for this pull request and updated news PR links. Best!

Copy link
Member

@fredrikekre fredrikekre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Travis is one timeout and Arnoldi.

@tkelman tkelman merged commit ff7fae1 into JuliaLang:master Aug 7, 2017
@Sacha0
Copy link
Member Author

Sacha0 commented Aug 7, 2017

Thanks all! :)

@Sacha0 Sacha0 deleted the devecspvec branch August 7, 2017 19:22
@JeffBezanson
Copy link
Sponsor Member

This is truly a glorious moment.

@StefanKarpinski
Copy link
Sponsor Member

Wow, is this really the last of the vectorized methods? That is momentous.

@Sacha0
Copy link
Member Author

Sacha0 commented Aug 7, 2017

I suspect pockets of resistance remain, hopefully to be smoked out prior to The Great Feature Freeze.

@StefanKarpinski
Copy link
Sponsor Member

StefanKarpinski commented Aug 7, 2017

Hmm. I wonder if there's a way to automatically search for vectorized methods...

@StefanKarpinski
Copy link
Sponsor Member

StefanKarpinski commented Aug 7, 2017

Ok, I found some lingerers by the very high tech means of grepping for vectoriz in the code base:

julia/base/dates/io.jl

Lines 561 to 580 in 0f4229d

# vectorized
function DateTime(Y::AbstractArray{<:AbstractString}, f::AbstractString; locale::Locale=ENGLISH)
DateTime(Y, DateFormat(f, locale))
end
function DateTime(Y::AbstractArray{<:AbstractString}, df::DateFormat=ISODateTimeFormat)
return reshape(DateTime[parse(DateTime, y, df) for y in Y], size(Y))
end
function Date(Y::AbstractArray{<:AbstractString}, f::AbstractString; locale::Locale=ENGLISH)
Date(Y, DateFormat(f, locale))
end
function Date(Y::AbstractArray{<:AbstractString}, df::DateFormat=ISODateFormat)
return reshape(Date[Date(parse(Date, y, df)) for y in Y], size(Y))
end
function format(Y::AbstractArray{<:TimeType}, f::AbstractString; locale::Locale=ENGLISH)
format(Y, DateFormat(f, locale))
end
function format(Y::AbstractArray{T}, df::DateFormat=default_format(T)) where T<:TimeType
return reshape([format(y, df) for y in Y], size(Y))
end

Issue opened: #23167.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
broadcast Applying a function over a collection deprecation This change introduces or involves a deprecation sparse Sparse arrays
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants