Doc warn and warn_with #23441
Merged
Doc warn and warn_with #23441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kshyatt
added
docs
ararslan
reviewed
Aug 27, 2017
base/libgit2/types.jl
Outdated
| @@ -849,6 +853,15 @@ end | |||
|
|
|||
| with(f::Function, ::Type{T}, args...) where {T} = with(f, T(args...)) | |||
|
|
|||
| """ | |||
| with_warn(f::Function, ::Type{T}, args..) | |||
There was a problem hiding this comment.
Missing a trailing dot on args
ararslan
reviewed
Aug 27, 2017
base/libgit2/types.jl
Outdated
| with_warn(f::Function, ::Type{T}, args..) | ||
|
|
||
| Resource management helper function. Apply `f` to `args`, first constructing | ||
| an instance of type `T` out of them. Makes sure to call `close` on the resulting |
There was a problem hiding this comment.
"Out of them" sounds confusing on first read. Maybe "first constructing an instance of type T using the given arguments"?
ararslan
approved these changes
Aug 29, 2017
|
Looks like we had a Mac timeout. I find the CircleCI logs really hard to read - is the fail there my fault? |
|
The Circle logs never even load for me (as an aside, that's why I made #23417, though that seems unlikely to be merged), so I'm also not sure. But I don't think Circle runs the doc stuff so it's likely unrelated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.